From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id EC14DE0082D; Wed, 4 Feb 2015 10:34:30 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.177 listed in list.dnswl.org] Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 584E4E00753 for ; Wed, 4 Feb 2015 10:34:28 -0800 (PST) Received: by mail-wi0-f177.google.com with SMTP id r20so5655842wiv.4 for ; Wed, 04 Feb 2015 10:34:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=OxwYSd7OTKFsDmnq3ArlnB8zxn5h/DbrX1Eox5qn474=; b=PKVzpWSpdt0dSxUXb10jWrbyE9OJMbI6gyU+LHqhIyVuTKM4DHbd9noi7IbDlrc9+d CVTFg5h5VhE75QUg51YQApZgPHbhwDTaKrM1YAGBes7sXOA9DR60lKFub6l1/xyICyNR ttflEQb3vprmSPmo85S427QAch+qYMzyCPb8H+L2nq+hHMVSfT/gzsso4/36jfc4kmW6 0WCkLnjuB6HiqDrp9OtMSWpzAzs3aB8rqRQQdPoC8enkSXuOFCVtiJJVU0dZgMl4H1On m9sYiA/PXCyfdY2LspGkUrP4rSK52yxvQP7GfKZUhyKNeA+a1AmHEM5+lOg/myFewjhe tXWA== X-Gm-Message-State: ALoCoQnc5STCm0PDAwztUw5dlb13v4Pyzbv1fO95nc1h7R/0g+hmasYZ6vayTgLR5zFePusv2CZa X-Received: by 10.194.89.38 with SMTP id bl6mr2390344wjb.146.1423074866084; Wed, 04 Feb 2015 10:34:26 -0800 (PST) Received: from [192.168.2.143] ([83.217.123.106]) by mx.google.com with ESMTPSA id vq9sm3873318wjc.6.2015.02.04.10.34.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Feb 2015 10:34:25 -0800 (PST) Message-ID: <54D26630.5000608@intel.com> Date: Wed, 04 Feb 2015 18:34:24 +0000 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: "Barros Pena, Belen" , "toaster@yoctoproject.org" References: <54CBD238.1010206@intel.com> In-Reply-To: <54CBD238.1010206@intel.com> Subject: Re: Review of "all machines" page X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Feb 2015 18:34:31 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Update 2 HEAD @ commit 469c5b7428248935ea3b95228e5292445e34de96 poky-contrib michaelw/all-machines On 30/01/15 18:49, Michael Wood wrote: > Current work in progress available for testing at poky-contrib > michaelw/all-machines > > (If there's no in-line comment it's an item that's still TODO). > > Michael > > On 06/11/14 16:53, Barros Pena, Belen wrote: >> I was asked to review the state of all machines page >> (https://bugzilla.yoctoproject.org/show_bug.cgi?id=6593 currently >> assigned >> to Michael) to give an idea of how much work is left to do. The short >> answer is: quite a bit. >> >> This is the list of issues I've found >> >> >> * The "Show rows" menu doesn't seem to be working properly. When you >> load >> the page, the table always shows 10 rows, independently of the value >> selected in the "show rows" menu > Fixed > >> >> * The machine name should not have a blue icon next to it > Fixed >> >> * The machine file information is not coming in > Unfortunately we have no information available on the machine file > that I can find to display > Fixed (update 2) >> >> * The layer name should be a link to the layer details page > Fixed >> >> * The branch, tag or commit column always shows a commit. For machines >> coming from layers from the OpenEmbedded layer source, this column >> should >> be showing a branch name instead >> Fixed (update 2) >> * The help text in the "add layer" buttons is currently hardcoded (it >> shows the same layer name for all machines) > Fixed >> >> * You cannot add layers / select machine functionality is not in place > Fixed - Apart from the funny tooltip thing will come back to this >> >> * The 'layer' column should be sortable (currently isn't) Fixed (update 2) >> >> * Sorting and the "edit columns" menu do not interact as explained in >> page >> 21 of the design document >> >> * Sorting by layer source reverts the sorting by machine, setting it >> to z >> to a. This should not happen: when I sort by layer source, machines with >> the same layer source should be sorted in alphabetical order (a to z) >> >> * The "select" column filter is not in place >> Fixed (update 2) >> * When applying a filter, the page heading does not update to show the >> number of results returned by the filter >> Was this for filters or Search? I've implemented it for search but I didn't see in the designs the same thing happens for filters. >> * It doesn't look like the search functionality is in place. When you >> try >> to search, you get an error saying that the "Machine object has no >> attribute 'search_allowed_fields'". This is the full trace: > Think this last one is fixed at least I couldn't reproduce it. The no > results state is missing.