From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Laight <David.Laight@ACULAB.COM>,
'Chen Gang S' <gang.chen@sunrus.com.cn>,
"marcel@holtmann.org" <marcel@holtmann.org>,
"gustavo@padovan.org" <gustavo@padovan.org>,
"johan.hedberg@gmail.com" <johan.hedberg@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] net: bluetooth: hci_sock: Use 'const void *' instead of 'void *' for 2nd parameter of hci_test_bit()
Date: Wed, 04 Feb 2015 23:13:28 +0300 [thread overview]
Message-ID: <54D27D68.7040501@cogentembedded.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CADA5E1@AcuExch.aculab.com>
Hello.
On 02/04/2015 02:59 PM, David Laight wrote:
>> -static inline int hci_test_bit(int nr, void *addr)
>> +static inline int hci_test_bit(int nr, const void *addr)
>> {
>> return *((__u32 *) addr + (nr >> 5)) & ((__u32) 1 << (nr & 31));
>> }
> Is there a 'standard' function lurking that will do the above.
> On x86 the cpus 'bit test' instruction will handle bit numbers
> greater than the word size - so it can be a single instruction.
Of course, there's test_bit().
> David
WBR, Sergei
next prev parent reply other threads:[~2015-02-04 20:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 21:14 [PATCH v2] net: bluetooth: hci_sock: Use 'const void *' instead of 'void *' for 2nd parameter of hci_test_bit() Chen Gang S
2015-02-02 21:14 ` Chen Gang S
2015-02-02 21:20 ` Joe Perches
2015-02-02 21:20 ` Joe Perches
2015-02-03 2:32 ` Chen Gang S
2015-02-03 2:32 ` Chen Gang S
2015-02-03 2:59 ` Chen Gang S
2015-02-04 12:13 ` David Laight
2015-02-04 12:13 ` David Laight
2015-02-04 12:13 ` David Laight
2015-02-04 11:59 ` David Laight
2015-02-04 11:59 ` David Laight
2015-02-04 11:59 ` David Laight
2015-02-04 20:13 ` Sergei Shtylyov [this message]
2015-02-04 21:09 ` Marcel Holtmann
2015-02-04 21:09 ` Marcel Holtmann
2015-02-04 21:47 ` Chen Gang S
2015-02-05 10:14 ` David Laight
2015-02-05 10:14 ` David Laight
2015-02-05 12:20 ` Chen Gang S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D27D68.7040501@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=gang.chen@sunrus.com.cn \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.