From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ6kD-0003Lc-35 for qemu-devel@nongnu.org; Wed, 04 Feb 2015 15:40:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJ6kA-0004Nb-Dv for qemu-devel@nongnu.org; Wed, 04 Feb 2015 15:40:17 -0500 Received: from omzsmtpe04.verizonbusiness.com ([199.249.25.207]:36277) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ6kA-0004N2-8d for qemu-devel@nongnu.org; Wed, 04 Feb 2015 15:40:14 -0500 From: Don Slutz Message-ID: <54D283A6.4000803@terremark.com> Date: Wed, 04 Feb 2015 15:40:06 -0500 MIME-Version: 1.0 References: <1423049158-20483-1-git-send-email-marcel@redhat.com> In-Reply-To: <1423049158-20483-1-git-send-email-marcel@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vl.c: fixed QEMU crash if no display was selected in command line List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, kraxel@redhat.com, xen-devel A proper fix for this is the thread: Subject: [PATCH v2 0/3] fix qemu crash about vnc Date: Fri, 30 Jan 2015 10:14:33 +0800 Message-ID: <1422584076-5728-1-git-send-email-arei.gonglei@huawei.com> This also has a bug: https://bugs.launchpad.net/qemu/+bug/1414222 Xen expects this to be working. -Don Slutz On 02/04/15 06:25, Marcel Apfelbaum wrote: > Commit 4db14629c3 (vnc: switch to QemuOpts, allow multiple servers) > converted vnc option to QemuOpts. > However, the default vnc display had ...,to=99,... between parameters > that is not covered by the QemuOpts. > Remove it because is not longer used and solves the crash. > > Signed-off-by: Marcel Apfelbaum > --- > This issue is bugging me some time now. Please let me know if > I got it wrong. > > vl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/vl.c b/vl.c > index 983259b..c8f33d2 100644 > --- a/vl.c > +++ b/vl.c > @@ -3970,7 +3970,7 @@ int main(int argc, char **argv, char **envp) > #elif defined(CONFIG_SDL) || defined(CONFIG_COCOA) > display_type = DT_SDL; > #elif defined(CONFIG_VNC) > - vnc_parse_func("localhost:0,to=99,id=default"); > + vnc_parse_func("localhost:0,id=default"); > show_vnc_port = 1; > #else > display_type = DT_NONE; >