From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH RFC 18/35] arm : add helper function for
 setting interrupt type
Date: Wed, 04 Feb 2015 21:59:59 +0000
Message-ID: <54D2965F.80809@linaro.org>
References: <1423058539-26403-1-git-send-email-parth.dixit@linaro.org>
	<1423058539-26403-19-git-send-email-parth.dixit@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1423058539-26403-19-git-send-email-parth.dixit@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: parth.dixit@linaro.org, xen-devel@lists.xen.org
Cc: christoffer.dall@linaro.org, tim@xen.org, stefano.stabellini@citrix.com, ian.campbell@citrix.com, jbeulich@suse.com
List-Id: xen-devel@lists.xenproject.org

Hi Parth,

On 04/02/2015 14:02, parth.dixit@linaro.org wrote:
> From: Parth Dixit <parth.dixit@linaro.org>
>
> set edge/level type information for an interrupt
>
> Signed-off-by: Parth Dixit <parth.dixit@linaro.org>
> ---
>   xen/arch/arm/irq.c        | 19 +++++++++++++++++++
>   xen/include/asm-arm/irq.h |  4 ++++
>   2 files changed, 23 insertions(+)
>
> diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
> index 25ecf1d..ae4e99a 100644
> --- a/xen/arch/arm/irq.c
> +++ b/xen/arch/arm/irq.c
> @@ -545,6 +545,25 @@ int platform_get_irq(const struct dt_device_node *device, int index)
>       return irq;
>   }
>
> +#if defined(CONFIG_ARM_64) && defined(CONFIG_ACPI)
> +int acpi_set_irq(int irq,int type)
> +{
> +    int res;
> +
> +    /* Setup the IRQ type */
> +    if ( irq < NR_LOCAL_IRQS )
> +        res = irq_local_set_type(irq, type);
> +    else
> +        res = irq_set_spi_type(irq, type);
> +
> +    if ( res )
> +        return -1;
> +
> +    return 0;
> +
> +}
> +#endif
> +

IIRC Ian was requiring a similar function for PCI. So I would rename to 
a generic name.

Also, now that we start to support ACPI the name of the define DT_IRQ_* 
are not anymore relevant. Maybe we should rename it.

Regards,

-- 
Julien Grall