All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libvips: requires C++ support
Date: Thu, 5 Feb 2015 14:49:39 +0100	[thread overview]
Message-ID: <54D374F3.1040508@imgtec.com> (raw)
In-Reply-To: <20150205144633.06790e8f@free-electrons.com>

Hi Thomas,

uhm..., the think if you use "--disable-cxx", the .so library is not
built and then it fails because is not found...

Maybe this is something we should report upstream?

Regards,
--
Vincent

On 05/02/15 14:46, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
> 
> On Thu, 5 Feb 2015 13:42:28 +0000, Vicente Olivert Riera wrote:
>> libvips requires C++ support, otherwise it will fail with an error
>> message like this one:
>>
>> error: ../libvips/.libs/libvips.so: No such file or directory
>>
>> Fixes:
>>
>>   http://autobuild.buildroot.net/results/cdc7cf5d3501f80c74b70aa09f93b2ad4e2f8602/
>>   http://autobuild.buildroot.net/results/39173dbcbbd0a243900ea583cec024b51f8b803a/
>>   http://autobuild.buildroot.net/results/6794705195bcdb636a8e6582ef5a1e153d4d66b3/
>>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> 
> This doesn't make sense with the contents of libvips.mk:
> 
> ifeq ($(BR2_INSTALL_LIBSTDCPP),y)
> LIBVIPS_CONF_OPTS += --enable-cxx
> else
> LIBVIPS_CONF_OPTS += --disable-cxx
> endif
> 
> So either we can disable C++, and your patch is not correct. Or
> disabling C++ doesn't work, and your patch should be amended to remove
> the BR2_INSTALL_LIBSTDCPP condition.
> 
> Best regards,
> 
> Thomas
> 

  reply	other threads:[~2015-02-05 13:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05 13:42 [Buildroot] [PATCH] libvips: requires C++ support Vicente Olivert Riera
2015-02-05 13:46 ` Thomas Petazzoni
2015-02-05 13:49   ` Vicente Olivert Riera [this message]
2015-02-05 13:51     ` Thomas Petazzoni
2015-02-05 13:52       ` Vicente Olivert Riera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D374F3.1040508@imgtec.com \
    --to=vincent.riera@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.