From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH RFC 04/35] ACPI / ACPICA: Introduce ARM Boot Architecture Flags in FADT Date: Thu, 05 Feb 2015 22:09:22 +0800 Message-ID: <54D37992.8090600@linaro.org> References: <1423058539-26403-1-git-send-email-parth.dixit@linaro.org> <1423058539-26403-5-git-send-email-parth.dixit@linaro.org> <54D2892F.2040803@linaro.org> <1423134417.24924.68.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1423134417.24924.68.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Naresh Bhat , tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, jbeulich@suse.com, parth.dixit@linaro.org, christoffer.dall@linaro.org List-Id: xen-devel@lists.xenproject.org Hi Ian, On 05/02/2015 19:06, Ian Campbell wrote: > On Wed, 2015-02-04 at 21:03 +0000, Julien Grall wrote: >>> -/* Masks for FADT Boot Architecture Flags (boot_flags) */ >>> +/* Masks for FADT IA-PC Boot Architecture Flags (boot_flags) [Vx]=Introduced in this FADT revision */ >> >> What does "this FADT revision" means? Please be more specific by giving >> the version. > > Isn't it a reference to the comments on each of the following entries > which start [V2], [V3], etc? Ah right, I was confused because this patch doesn't add any [Vx], but only update the comment. The commit message should be updated to reflex this thing. BTW, shouldn't we precise the version of the PSCI flags? Regards, -- Julien Grall