Re: [Qemu-devel] [PATCH RFC v4 1/6] qemu-iotests: run qemu with -nodefaults

[Max Reitz <mreitz@redhat.com>]

On 2015-02-04 at 22:44, Xiao Guang Chen wrote:
> This patch fixes an io test suite issue that was introduced with the
> commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only
> a single "stdio" character device'. The option supresses the creation of
> default devices.
>
> Reviewed-by: Michael Mueller <mimu@linux.vnet.ibm.com>
> Signed-off-by: Xiao Guang Chen <chenxg@linux.vnet.ibm.com>
> ---
>   tests/qemu-iotests/common        | 1 +
>   tests/qemu-iotests/common.config | 2 +-
>   tests/qemu-iotests/common.qemu   | 2 +-
>   3 files changed, 3 insertions(+), 2 deletions(-)

I think this patch and patch 3 are fine, but there is no reason not to 
squash 3 into 1. The reason I'm suggesting that once again is that it 
prevents tests 067, 071, and 087 from breaking (which would be a really 
nice thing).

So if you decide not to squash them I'll probably give an Reviewed-by 
anyway, but you really should consider doing it.

Max