From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCHv1] xenbus: Add proper handling of XS_ERROR
 from Xenbus for transactions.
Date: Thu, 5 Feb 2015 15:07:59 +0000
Message-ID: <54D3874F.3090106@citrix.com>
References: <1423148560-25957-1-git-send-email-david.vrabel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <david.vrabel@citrix.com>) id 1YJO2E-00060J-WD
	for xen-devel@lists.xenproject.org; Thu, 05 Feb 2015 15:08:03 +0000
In-Reply-To: <1423148560-25957-1-git-send-email-david.vrabel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>, xen-devel@lists.xenproject.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>, Jennifer Herbert <Jennifer.Herbert@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 05/02/15 15:02, David Vrabel wrote:
> From: Jennifer Herbert <Jennifer.Herbert@citrix.com>
> 
> If Xenstore sends back a XS_ERROR for TRANSACTION_END, the driver BUGs
> because it cannot find the matching transaction in the list.  For
> TRANSACTION_START, it leaks memory.
> 
> Check the message as returned from xenbus_dev_request_and_reply(), and
> clean up for TRANSACTION_START or discard the error for
> TRANSACTION_END.

Applied to devel/for-linus-3.20, thanks.

David