diff for duplicates of <54D3900A.9060200@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 446d558..ea2213c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -9,58 +9,3 @@ structclk-arm.patch is the result I got when applying it to the arch/arm directory Is there anything else I can do to help? - - --------------- next part -------------- -A non-text attachment was scrubbed... -Name: structclk-arm.patch -Type: text/x-patch -Size: 2512 bytes -Desc: not available -URL: <https://systeme.lip6.fr/pipermail/cocci/attachments/20150205/7f8a2e33/attachment.bin> --------------- next part -------------- -/// Find any attempt to compare or dereference struct clk pointers. -/// -// Confidence: High -// Copyright: (C) 2015 Quentin Lambert, INRIA/LiP6. GPLv2 -// URL: http://coccinelle.lip6.fr/ -// Options: --recursive-includes --relax-include-path -// Options: --include-headers-for-types - -virtual context -virtual org -virtual report - - -// ---------------------------------------------------------------------------- - -@comparison_dereference depends on context || org || report@ -struct clk *x1, x2; -position j0; -@@ - -( -* x1 at j0 == x2 -| -* x1 at j0 != x2 -| -* *x1 at j0 -) - -// ---------------------------------------------------------------------------- - -@script:python comparison_dereference_org depends on org@ -j0 << comparison_dereference.j0; -@@ - -msg = "WARNING trying to compare or dereference struct clk pointers." -coccilib.org.print_todo(j0[0], msg) - -// ---------------------------------------------------------------------------- - -@script:python comparison_dereference_report depends on report@ -j0 << comparison_dereference.j0; -@@ - -msg = "WARNING trying to compare or dereference struct clk pointers." -coccilib.report.print_report(j0[0], msg) diff --git a/N1/2.hdr b/N1/2.hdr new file mode 100644 index 0000000..12595e5 --- /dev/null +++ b/N1/2.hdr @@ -0,0 +1,5 @@ +Content-Type: text/x-patch; + name="structclk-arm.patch" +Content-Transfer-Encoding: 7bit +Content-Disposition: attachment; + filename="structclk-arm.patch" diff --git a/N1/2.txt b/N1/2.txt new file mode 100644 index 0000000..8ec7f33 --- /dev/null +++ b/N1/2.txt @@ -0,0 +1,66 @@ +diff -u -p ./arch/arm/mach-imx/mach-imx6q.c /tmp/nothing/mach-imx/mach-imx6q.c +--- ./arch/arm/mach-imx/mach-imx6q.c ++++ /tmp/nothing/mach-imx/mach-imx6q.c +@@ -211,7 +211,6 @@ static void __init imx6q_1588_init(void) + * set bit IOMUXC_GPR1[21]. Or the PTP clock must be from pad + * (external OSC), and we need to clear the bit. + */ +- clksel = ptp_clk == enet_ref ? IMX6Q_GPR1_ENET_CLK_SEL_ANATOP : + IMX6Q_GPR1_ENET_CLK_SEL_PAD; + gpr = syscon_regmap_lookup_by_compatible("fsl,imx6q-iomuxc-gpr"); + if (!IS_ERR(gpr)) +diff -u -p ./arch/arm/mach-shmobile/clock-r8a73a4.c /tmp/nothing/mach-shmobile/clock-r8a73a4.c +--- ./arch/arm/mach-shmobile/clock-r8a73a4.c ++++ /tmp/nothing/mach-shmobile/clock-r8a73a4.c +@@ -139,7 +139,6 @@ static int pll_set_parent(struct clk *cl + + /* Search the parent */ + for (i = 0; i < clk->parent_num; i++) +- if (clk->parent_table[i] == parent) + break; + + if (i == clk->parent_num) +diff -u -p ./arch/arm/mach-shmobile/clock-sh7372.c /tmp/nothing/mach-shmobile/clock-sh7372.c +--- ./arch/arm/mach-shmobile/clock-sh7372.c ++++ /tmp/nothing/mach-shmobile/clock-sh7372.c +@@ -223,7 +223,6 @@ static int pllc2_set_parent(struct clk * + + /* Search the parent */ + for (i = 0; i < clk->parent_num; i++) +- if (clk->parent_table[i] == parent) + break; + + if (i == clk->parent_num) +diff -u -p ./arch/arm/mach-shmobile/clock-r8a7740.c /tmp/nothing/mach-shmobile/clock-r8a7740.c +--- ./arch/arm/mach-shmobile/clock-r8a7740.c ++++ /tmp/nothing/mach-shmobile/clock-r8a7740.c +@@ -195,7 +195,6 @@ static int usb24s_set_parent(struct clk + + /* Search the parent */ + for (i = 0; i < clk->parent_num; i++) +- if (clk->parent_table[i] == parent) + break; + + if (i == clk->parent_num) +diff -u -p ./arch/arm/mach-omap2/clkt_clksel.c /tmp/nothing/mach-omap2/clkt_clksel.c +--- ./arch/arm/mach-omap2/clkt_clksel.c ++++ /tmp/nothing/mach-omap2/clkt_clksel.c +@@ -67,7 +67,6 @@ static const struct clksel *_get_clksel_ + return NULL; + + for (clks = clk->clksel; clks->parent; clks++) +- if (clks->parent == src_clk) + break; /* Found the requested parent */ + + if (!clks->parent) { +diff -u -p ./arch/arm/mach-omap2/timer.c /tmp/nothing/mach-omap2/timer.c +--- ./arch/arm/mach-omap2/timer.c ++++ /tmp/nothing/mach-omap2/timer.c +@@ -298,7 +298,6 @@ static int __init omap_dm_timer_init_one + if (IS_ERR(src)) + return PTR_ERR(src); + +- if (clk_get_parent(timer->fclk) != src) { + r = clk_set_parent(timer->fclk, src); + if (r < 0) { + pr_warn("%s: %s cannot set source\n", __func__, diff --git a/N1/3.hdr b/N1/3.hdr new file mode 100644 index 0000000..8541332 --- /dev/null +++ b/N1/3.hdr @@ -0,0 +1,5 @@ +Content-Type: text/plain; charset=UTF-8; + name="structclk.cocci" +Content-Transfer-Encoding: 7bit +Content-Disposition: attachment; + filename="structclk.cocci" diff --git a/N1/3.txt b/N1/3.txt new file mode 100644 index 0000000..85091fb --- /dev/null +++ b/N1/3.txt @@ -0,0 +1,45 @@ +/// Find any attempt to compare or dereference struct clk pointers. +/// +// Confidence: High +// Copyright: (C) 2015 Quentin Lambert, INRIA/LiP6. GPLv2 +// URL: http://coccinelle.lip6.fr/ +// Options: --recursive-includes --relax-include-path +// Options: --include-headers-for-types + +virtual context +virtual org +virtual report + + +// ---------------------------------------------------------------------------- + +@comparison_dereference depends on context || org || report@ +struct clk *x1, x2; +position j0; +@@ + +( +* x1@j0 == x2 +| +* x1@j0 != x2 +| +* *x1@j0 +) + +// ---------------------------------------------------------------------------- + +@script:python comparison_dereference_org depends on org@ +j0 << comparison_dereference.j0; +@@ + +msg = "WARNING trying to compare or dereference struct clk pointers." +coccilib.org.print_todo(j0[0], msg) + +// ---------------------------------------------------------------------------- + +@script:python comparison_dereference_report depends on report@ +j0 << comparison_dereference.j0; +@@ + +msg = "WARNING trying to compare or dereference struct clk pointers." +coccilib.report.print_report(j0[0], msg) diff --git a/a/content_digest b/N1/content_digest index c1aa3a0..ed687ec 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -7,11 +7,21 @@ "ref\020150202225036.421.43421@quantum\0" "ref\054D0F179.1040906@gmail.com\0" "ref\054D2AA9B.7010800@codeaurora.org\0" - "From\0lambert.quentin@gmail.com (Quentin Lambert)\0" - "Subject\0[Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances\0" + "From\0Quentin Lambert <lambert.quentin@gmail.com>\0" + "Subject\0Re: [Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances\0" "Date\0Thu, 05 Feb 2015 16:45:14 +0100\0" - "To\0cocci@systeme.lip6.fr\0" - "\00:1\0" + "To\0Stephen Boyd <sboyd@codeaurora.org>" + Mike Turquette <mturquette@linaro.org> + " Julia Lawall <julia.lawall@lip6.fr>\0" + "Cc\0Paul Walmsley <paul@pwsan.com>" + Tomeu Vizoso <tomeu.vizoso@collabora.com> + Tony Lindgren <tony@atomide.com> + linux-kernel@vger.kernel.org + t-kristo@ti.com + linux-omap@vger.kernel.org + cocci@systeme.lip6.fr + " linux-arm-kernel@lists.infradead.org\0" + "\01:1\0" "b\0" "\n" "On 05/02/2015 00:26, Stephen Boyd wrote:\n" @@ -23,17 +33,79 @@ "structclk-arm.patch is the result I got when applying it to the arch/arm \n" "directory\n" "\n" - "Is there anything else I can do to help?\n" - "\n" - "\n" - "-------------- next part --------------\n" - "A non-text attachment was scrubbed...\n" - "Name: structclk-arm.patch\n" - "Type: text/x-patch\n" - "Size: 2512 bytes\n" - "Desc: not available\n" - "URL: <https://systeme.lip6.fr/pipermail/cocci/attachments/20150205/7f8a2e33/attachment.bin>\n" - "-------------- next part --------------\n" + Is there anything else I can do to help? + "\01:2\0" + "fn\0structclk-arm.patch\0" + "b\0" + "diff -u -p ./arch/arm/mach-imx/mach-imx6q.c /tmp/nothing/mach-imx/mach-imx6q.c\n" + "--- ./arch/arm/mach-imx/mach-imx6q.c\n" + "+++ /tmp/nothing/mach-imx/mach-imx6q.c\n" + "@@ -211,7 +211,6 @@ static void __init imx6q_1588_init(void)\n" + " \t * set bit IOMUXC_GPR1[21]. Or the PTP clock must be from pad\n" + " \t * (external OSC), and we need to clear the bit.\n" + " \t */\n" + "-\tclksel = ptp_clk == enet_ref ? IMX6Q_GPR1_ENET_CLK_SEL_ANATOP :\n" + " \t\t\t\t IMX6Q_GPR1_ENET_CLK_SEL_PAD;\n" + " \tgpr = syscon_regmap_lookup_by_compatible(\"fsl,imx6q-iomuxc-gpr\");\n" + " \tif (!IS_ERR(gpr))\n" + "diff -u -p ./arch/arm/mach-shmobile/clock-r8a73a4.c /tmp/nothing/mach-shmobile/clock-r8a73a4.c\n" + "--- ./arch/arm/mach-shmobile/clock-r8a73a4.c\n" + "+++ /tmp/nothing/mach-shmobile/clock-r8a73a4.c\n" + "@@ -139,7 +139,6 @@ static int pll_set_parent(struct clk *cl\n" + " \n" + " \t/* Search the parent */\n" + " \tfor (i = 0; i < clk->parent_num; i++)\n" + "-\t\tif (clk->parent_table[i] == parent)\n" + " \t\t\tbreak;\n" + " \n" + " \tif (i == clk->parent_num)\n" + "diff -u -p ./arch/arm/mach-shmobile/clock-sh7372.c /tmp/nothing/mach-shmobile/clock-sh7372.c\n" + "--- ./arch/arm/mach-shmobile/clock-sh7372.c\n" + "+++ /tmp/nothing/mach-shmobile/clock-sh7372.c\n" + "@@ -223,7 +223,6 @@ static int pllc2_set_parent(struct clk *\n" + " \n" + " \t/* Search the parent */\n" + " \tfor (i = 0; i < clk->parent_num; i++)\n" + "-\t\tif (clk->parent_table[i] == parent)\n" + " \t\t\tbreak;\n" + " \n" + " \tif (i == clk->parent_num)\n" + "diff -u -p ./arch/arm/mach-shmobile/clock-r8a7740.c /tmp/nothing/mach-shmobile/clock-r8a7740.c\n" + "--- ./arch/arm/mach-shmobile/clock-r8a7740.c\n" + "+++ /tmp/nothing/mach-shmobile/clock-r8a7740.c\n" + "@@ -195,7 +195,6 @@ static int usb24s_set_parent(struct clk\n" + " \n" + " \t/* Search the parent */\n" + " \tfor (i = 0; i < clk->parent_num; i++)\n" + "-\t\tif (clk->parent_table[i] == parent)\n" + " \t\t\tbreak;\n" + " \n" + " \tif (i == clk->parent_num)\n" + "diff -u -p ./arch/arm/mach-omap2/clkt_clksel.c /tmp/nothing/mach-omap2/clkt_clksel.c\n" + "--- ./arch/arm/mach-omap2/clkt_clksel.c\n" + "+++ /tmp/nothing/mach-omap2/clkt_clksel.c\n" + "@@ -67,7 +67,6 @@ static const struct clksel *_get_clksel_\n" + " \t\treturn NULL;\n" + " \n" + " \tfor (clks = clk->clksel; clks->parent; clks++)\n" + "-\t\tif (clks->parent == src_clk)\n" + " \t\t\tbreak; /* Found the requested parent */\n" + " \n" + " \tif (!clks->parent) {\n" + "diff -u -p ./arch/arm/mach-omap2/timer.c /tmp/nothing/mach-omap2/timer.c\n" + "--- ./arch/arm/mach-omap2/timer.c\n" + "+++ /tmp/nothing/mach-omap2/timer.c\n" + "@@ -298,7 +298,6 @@ static int __init omap_dm_timer_init_one\n" + " \tif (IS_ERR(src))\n" + " \t\treturn PTR_ERR(src);\n" + " \n" + "-\tif (clk_get_parent(timer->fclk) != src) {\n" + " \t\tr = clk_set_parent(timer->fclk, src);\n" + " \t\tif (r < 0) {\n" + " \t\t\tpr_warn(\"%s: %s cannot set source\\n\", __func__," + "\01:3\0" + "fn\0structclk.cocci\0" + "b\0" "/// Find any attempt to compare or dereference struct clk pointers.\n" "///\n" "// Confidence: High\n" @@ -55,11 +127,11 @@ "@@\n" "\n" "(\n" - "* x1 at j0 == x2\n" + "* x1@j0 == x2\n" "|\n" - "* x1 at j0 != x2\n" + "* x1@j0 != x2\n" "|\n" - "* *x1 at j0\n" + "* *x1@j0\n" ")\n" "\n" "// ----------------------------------------------------------------------------\n" @@ -80,4 +152,4 @@ "msg = \"WARNING trying to compare or dereference struct clk pointers.\"\n" coccilib.report.print_report(j0[0], msg) -273f5452804fc35d0cb7882f2d6c794c4a1f39782dcfbcb097cba8c6a432f616 +e8aeceadcbc0031d0ab671dfaede6fea6d7b06f10e162dc1d8555a444d40f508
diff --git a/a/1.txt b/N2/1.txt index 446d558..b52a7bb 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -17,7 +17,7 @@ Name: structclk-arm.patch Type: text/x-patch Size: 2512 bytes Desc: not available -URL: <https://systeme.lip6.fr/pipermail/cocci/attachments/20150205/7f8a2e33/attachment.bin> +URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150205/7f8a2e33/attachment.bin> -------------- next part -------------- /// Find any attempt to compare or dereference struct clk pointers. /// diff --git a/a/content_digest b/N2/content_digest index c1aa3a0..f1dec11 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -10,7 +10,7 @@ "From\0lambert.quentin@gmail.com (Quentin Lambert)\0" "Subject\0[Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances\0" "Date\0Thu, 05 Feb 2015 16:45:14 +0100\0" - "To\0cocci@systeme.lip6.fr\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "\n" @@ -32,7 +32,7 @@ "Type: text/x-patch\n" "Size: 2512 bytes\n" "Desc: not available\n" - "URL: <https://systeme.lip6.fr/pipermail/cocci/attachments/20150205/7f8a2e33/attachment.bin>\n" + "URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150205/7f8a2e33/attachment.bin>\n" "-------------- next part --------------\n" "/// Find any attempt to compare or dereference struct clk pointers.\n" "///\n" @@ -80,4 +80,4 @@ "msg = \"WARNING trying to compare or dereference struct clk pointers.\"\n" coccilib.report.print_report(j0[0], msg) -273f5452804fc35d0cb7882f2d6c794c4a1f39782dcfbcb097cba8c6a432f616 +c21685aec8428599ce328aa2c25910ccf403fcdde3989436f969fc1ca7a98642
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.