All of lore.kernel.org
 help / color / mirror / Atom feed
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] Documentation: dt-bindings: add dt binding info for hi6220
Date: Thu, 05 Feb 2015 21:24:01 +0300	[thread overview]
Message-ID: <54D3B541.1070404@cogentembedded.com> (raw)
In-Reply-To: <1423147620-5760-3-git-send-email-zhangfei.gao@linaro.org>

Hello.

On 02/05/2015 05:46 PM, Zhangfei Gao wrote:

> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> ---
>   .../devicetree/bindings/usb/hi6220-usb.txt         | 50 ++++++++++++++++++++++
>   1 file changed, 50 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/usb/hi6220-usb.txt

> diff --git a/Documentation/devicetree/bindings/usb/hi6220-usb.txt b/Documentation/devicetree/bindings/usb/hi6220-usb.txt
> new file mode 100644
> index 0000000..e926364
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/hi6220-usb.txt
> @@ -0,0 +1,50 @@
> +Hisilicon hi6220  SoC USB controlle

    Controller.

> +-----------------------------
> +
> +usb controller is inherited from dwc2, refer dwc2.txt
> +-----
> +
> +Required properties:
> +- compatible: "hisilicon,hi6220-usb-phy"

    PHY? I thought you were describing the USB controller.

> +Refer to dwc2.txt for dwc2 usb properties
> +
> +
> +phy:
> +-----
> +
> +Required properties:
> +- compatible: "hisilicon,hi6220-usb-phy"
> +- vcc-supply: phandle to the regulator that provides power to the PHY.
> +- clocks: phandle to the PHY clock. Use as per Documentation/devicetree

    Actually, it's phandle and clock specifier.

> +  /bindings/clock/clock-bindings.txt
> +- hisilicon,peripheral-syscon: phandle of syscon used to control peripheral.
> +- hisilicon,gpio_vbus_det: gpio of detecting vbus.
> +- hisilicon,gpio_id_det: gpio of detecting id.

    Hyphens are preferred over underscores in the prop names.

[...]

WBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: Zhangfei Gao
	<zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	balbi-l0cyMroinI0@public.gmane.org,
	john.youn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org,
	Mian Yousaf Kaukab
	<yousaf.kaukab-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"dan . zhao" <dan.zhao-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/4] Documentation: dt-bindings: add dt binding info for hi6220
Date: Thu, 05 Feb 2015 21:24:01 +0300	[thread overview]
Message-ID: <54D3B541.1070404@cogentembedded.com> (raw)
In-Reply-To: <1423147620-5760-3-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Hello.

On 02/05/2015 05:46 PM, Zhangfei Gao wrote:

> Signed-off-by: Zhangfei Gao <zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>   .../devicetree/bindings/usb/hi6220-usb.txt         | 50 ++++++++++++++++++++++
>   1 file changed, 50 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/usb/hi6220-usb.txt

> diff --git a/Documentation/devicetree/bindings/usb/hi6220-usb.txt b/Documentation/devicetree/bindings/usb/hi6220-usb.txt
> new file mode 100644
> index 0000000..e926364
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/hi6220-usb.txt
> @@ -0,0 +1,50 @@
> +Hisilicon hi6220  SoC USB controlle

    Controller.

> +-----------------------------
> +
> +usb controller is inherited from dwc2, refer dwc2.txt
> +-----
> +
> +Required properties:
> +- compatible: "hisilicon,hi6220-usb-phy"

    PHY? I thought you were describing the USB controller.

> +Refer to dwc2.txt for dwc2 usb properties
> +
> +
> +phy:
> +-----
> +
> +Required properties:
> +- compatible: "hisilicon,hi6220-usb-phy"
> +- vcc-supply: phandle to the regulator that provides power to the PHY.
> +- clocks: phandle to the PHY clock. Use as per Documentation/devicetree

    Actually, it's phandle and clock specifier.

> +  /bindings/clock/clock-bindings.txt
> +- hisilicon,peripheral-syscon: phandle of syscon used to control peripheral.
> +- hisilicon,gpio_vbus_det: gpio of detecting vbus.
> +- hisilicon,gpio_id_det: gpio of detecting id.

    Hyphens are preferred over underscores in the prop names.

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-02-05 18:24 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05 14:46 [PATCH 0/4] add usb support for hi6220 Zhangfei Gao
2015-02-05 14:46 ` Zhangfei Gao
2015-02-05 14:46 ` [PATCH 1/4] Documentation: dt-bindings: add dt binding info for hi6220 dwc2 Zhangfei Gao
2015-02-05 14:46   ` Zhangfei Gao
2015-02-05 14:46 ` [PATCH 2/4] Documentation: dt-bindings: add dt binding info for hi6220 Zhangfei Gao
2015-02-05 14:46   ` Zhangfei Gao
2015-02-05 18:24   ` Sergei Shtylyov [this message]
2015-02-05 18:24     ` Sergei Shtylyov
2015-02-06  5:49     ` Zhangfei Gao
2015-02-06  5:49       ` Zhangfei Gao
2015-02-05 14:46 ` [PATCH 3/4] usb: dwc2: platform: add hi6220 support Zhangfei Gao
2015-02-05 14:46   ` Zhangfei Gao
2015-02-05 14:47 ` [PATCH 4/4] usb: phy: add phy-hi6220 Zhangfei Gao
2015-02-05 14:47   ` Zhangfei Gao
2015-02-06  8:41   ` Peter Chen
2015-02-06  8:41     ` Peter Chen
2015-02-06 11:47     ` Zhangfei Gao
2015-02-06 11:47       ` Zhangfei Gao
2015-02-09  1:57       ` Peter Chen
2015-02-09  1:57         ` Peter Chen
2015-02-09  3:31         ` Zhangfei Gao
2015-02-09  3:31           ` Zhangfei Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D3B541.1070404@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.