From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 486F8E00894; Thu, 5 Feb 2015 11:00:51 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [74.125.82.52 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 965A7E007AB for ; Thu, 5 Feb 2015 11:00:44 -0800 (PST) Received: by mail-wg0-f52.google.com with SMTP id y19so9260147wgg.11 for ; Thu, 05 Feb 2015 11:00:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=Gi/qdKTTNb2ca60zpV/yyzcwbCB7u6l2IIKtx3h41mo=; b=fZpOJkfYE3kZVK6+2kutuweMNyMScaF5S1u463M+WVXwgKITPbZdnU1MzEF52xl0yE fmA23LiDYhYMF3c/BQLEOxZOzh8Q/grhkBscFAdvG3TCCS9vWEs1PHUXjqa4Dvqq+TA8 FKV03xMevFIKvfX1IGiWwOHda5Fzv6grYs8GfJlwYYXrNLH+7R8c8rmGfnrQriKirgaV JzGNxHFMBJkJ32A3luTEod9ZACfE1ndfKeYRR+q3TuXQzhx1aZo7qDSOnR2DZROVcbu4 s4qF2/DtHNTzWd/Du7fQ5ZiH9Vp87cC9m2+iEk8MZIukJX5S6XMUinwtJPx/sWlYed25 50+Q== X-Gm-Message-State: ALoCoQl4viW66UMggyHpLtnvvcH87QUrPXjTNsR7JdKq9LrMvhBtw8IBcP+0I+nl24KVNZ/y+8FH X-Received: by 10.194.237.34 with SMTP id uz2mr10505634wjc.157.1423162839298; Thu, 05 Feb 2015 11:00:39 -0800 (PST) Received: from [192.168.2.143] ([83.217.123.106]) by mx.google.com with ESMTPSA id kj8sm15817wjc.29.2015.02.05.11.00.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Feb 2015 11:00:38 -0800 (PST) Message-ID: <54D3BDD6.6030405@intel.com> Date: Thu, 05 Feb 2015 19:00:38 +0000 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: "Barros Pena, Belen" , "toaster@yoctoproject.org" References: <54CBD238.1010206@intel.com> <54D26630.5000608@intel.com> In-Reply-To: <54D26630.5000608@intel.com> Subject: Re: Review of "all machines" page X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Feb 2015 19:00:51 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Latest Update 3 HEAD cd28aecfa1119d31b085ff7eb4447e138ac76eb2 poky-contrib michaelw/all-machines >> * In the no results page, the word "Machines" in the heading should not be >> capitalised, to match all other states of the heading > Fixed (update 3) > * Something funny going on with the layers: the openembedded-core layer > appears as if it is not added to the project, but it is definitely added > (it is added by default to all our projects). What's worse, when you click > on 'add layer', you actually end up with 2 openembedded-core layers added > to the project. When you hover over the second one, it seems to be coming > from the oe repo, instead of the poky repo, and has not branch. I am not > sure how up-to-date your branch is with master. If it is fully up-to-date, > something has broken down with the layers :/ Fixed (update 3) Yes Alex was explaining that this was likely to happen because we'll see duplicates if we get the same layer but from a different source. It's going to make the page pretty slow. >> * Also in the no results page, the "show all machines" link is not >> working. When you click on it, nothing happens. > Fixed (update 3) >>> >>> * The "Show rows" menu doesn't seem to be working properly. When you >>> load >>> the page, the table always shows 10 rows, independently of the value >>> selected in the "show rows" menu >> Fixed >> >>> >>> * The machine name should not have a blue icon next to it >> Fixed >>> >>> * The machine file information is not coming in >> Unfortunately we have no information available on the machine file >> that I can find to display >> > > Fixed (update 2) > >>> >>> * The layer name should be a link to the layer details page >> Fixed >>> >>> * The branch, tag or commit column always shows a commit. For machines >>> coming from layers from the OpenEmbedded layer source, this column >>> should >>> be showing a branch name instead >>> > > Fixed (update 2) > > >>> * The help text in the "add layer" buttons is currently hardcoded (it >>> shows the same layer name for all machines) >> Fixed >>> >>> * You cannot add layers / select machine functionality is not in place >> Fixed - Apart from the funny tooltip thing will come back to this >>> >>> * The 'layer' column should be sortable (currently isn't) > > Fixed (update 2) > >>> >>> * Sorting and the "edit columns" menu do not interact as explained >>> in page >>> 21 of the design document >>> Fixed (update 3) >>> * Sorting by layer source reverts the sorting by machine, setting it >>> to z >>> to a. This should not happen: when I sort by layer source, machines >>> with >>> the same layer source should be sorted in alphabetical order (a to z) > Fixed I think (update 3) >>> >>> * The "select" column filter is not in place >>> > > Fixed (update 2) > >>> * When applying a filter, the page heading does not update to show the >>> number of results returned by the filter >>> > > > Was this for filters or Search? I've implemented it for search but I > didn't see in the designs the same thing happens for filters. > A: Both Fixed (update 3) Things coming back to also for layerdetails - Funny tooltip thing - machine change confirm Michael