All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: riel@redhat.com, rkrcmar@redhat.com, mtosatti@redhat.com
Subject: Re: [PATCH RFC] kvm: x86: add halt_poll module parameter
Date: Thu, 05 Feb 2015 20:20:54 +0100	[thread overview]
Message-ID: <54D3C296.7030207@redhat.com> (raw)
In-Reply-To: <54D3BC94.9010007@siemens.com>



On 05/02/2015 19:55, Jan Kiszka wrote:
> > This patch introduces a new module parameter for the KVM module; when it
> > is present, KVM attempts a bit of polling on every HLT before scheduling
> > itself out via kvm_vcpu_block.
>
> Wouldn't it be better to tune this on a per-VM basis? Think of mixed
> workloads with some latency-sensitive and some standard VMs.

Yes, but:

1) this turned out to be very cheap, so a per-host tunable is not too bad;

2) it also affects only very few workloads (for example network
workloads can already do polling in the guest) so it only affects few
people;

3) long term anyway we want it to auto tune, which is better than tuning
it per-VM.

Paolo

  reply	other threads:[~2015-02-05 19:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05 16:05 [PATCH RFC] kvm: x86: add halt_poll module parameter Paolo Bonzini
2015-02-05 17:46 ` Rik van Riel
2015-02-05 17:53 ` Radim Krčmář
2015-02-05 19:18   ` Paolo Bonzini
2015-02-05 18:55 ` Jan Kiszka
2015-02-05 19:20   ` Paolo Bonzini [this message]
2015-02-05 19:23     ` Rik van Riel
2015-02-05 20:14       ` Paolo Bonzini
2015-02-05 20:39 ` David Matlack
2015-02-05 21:24   ` Paolo Bonzini
2015-02-05 23:34 ` Marcelo Tosatti
2015-02-05 23:47   ` Marcelo Tosatti
2015-02-06  7:50   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D3C296.7030207@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=riel@redhat.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.