Re: [Qemu-devel] [PATCH v4 12/16] qemu-io: Remove "growable" option

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1399 bytes --]

On 02/05/2015 11:58 AM, Max Reitz wrote:
> Remove "growable" option from the "open" command and from the qemu-io
> command line. qemu-io is about to be converted to BlockBackend which
> will make sure that no request exceeds the image size, so the only way
> to keep "growable" would be to use BlockBackend if it is not given and
> to directly access the BDS if it is.
> 
> qemu-io is a debugging tool, therefore removing a rarely used option
> will have only a very small impact, if any. There was only one
> qemu-iotest which used the option; since it is not critical, this patch
> just removes it.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  qemu-io.c                  | 23 +++------------
>  tests/qemu-iotests/016     | 73 ----------------------------------------------
>  tests/qemu-iotests/016.out | 23 ---------------
>  tests/qemu-iotests/group   |  2 +-
>  4 files changed, 5 insertions(+), 116 deletions(-)
>  delete mode 100755 tests/qemu-iotests/016
>  delete mode 100644 tests/qemu-iotests/016.out
> 

> +++ b/tests/qemu-iotests/group
> @@ -22,7 +22,7 @@
>  013 rw auto
>  014 rw auto
>  015 rw snapshot auto
> -016 rw auto quick
> +# 016 was removed, do not reuse

Works for me.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]