From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH RFC 27/35] arm: acpi map mmio regions to dom0
Date: Fri, 06 Feb 2015 08:44:13 +0800
Message-ID: <54D40E5D.4090905@linaro.org>
References: <1423058539-26403-1-git-send-email-parth.dixit@linaro.org>	<1423058539-26403-28-git-send-email-parth.dixit@linaro.org>	<alpine.DEB.2.02.1502051648050.29696@kaball.uk.xensource.com>
	<CABy3MNn7Re4HXd7Hbno9PJ5Ti-KOgACqMF9j7RuqxiLVMaJJKw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CABy3MNn7Re4HXd7Hbno9PJ5Ti-KOgACqMF9j7RuqxiLVMaJJKw@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Parth Dixit <parth.dixit@linaro.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>, tim@xen.org, xen-devel <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Jan Beulich <jbeulich@suse.com>, Christoffer Dall <christoffer.dall@linaro.org>
List-Id: xen-devel@lists.xenproject.org

On 06/02/2015 03:40, Parth Dixit wrote:
>>> +static int map_acpi_regions(struct domain *d)
>>> +{
>>> +    int res;
>>> +
>>> +    res = acpi_map_mmio(d);
>>> +    if ( res )
>>> +        return res;
>>> +
>>> +    return 0;
>>> +}
>>
>> I don't think that splitting the code in two functions is useful. Just
>> implement the remapping here.
> ok, will take care in next patchset.

I agree that the splitting doesn't make really sense right now (only one 
call is done). But the next following patches add few more calls (such 
has mapping ACPI blob...).

So I would keep the splitting here. I would also rename the function to 
prepare_acpi to make clear that we setups ACPI for DOM0.

-- 
Julien Grall