From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41269)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YJdw0-0004Eo-Bm
	for qemu-devel@nongnu.org; Fri, 06 Feb 2015 03:06:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YJdvw-0000gx-Cf
	for qemu-devel@nongnu.org; Fri, 06 Feb 2015 03:06:40 -0500
Received: from szxga02-in.huawei.com ([119.145.14.65]:2419)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YJdvv-0000gf-OZ
	for qemu-devel@nongnu.org; Fri, 06 Feb 2015 03:06:36 -0500
Message-ID: <54D475CD.1050707@huawei.com>
Date: Fri, 6 Feb 2015 16:05:33 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <1422966857-6776-1-git-send-email-arei.gonglei@huawei.com>
In-Reply-To: <1422966857-6776-1-git-send-email-arei.gonglei@huawei.com>
Content-Type: text/plain; charset="GB2312"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 0/3] bootdevcie: change the boot order
	validation logic
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: "armbru@redhat.com" <armbru@redhat.com>, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, "dvaleev@suse.de" <dvaleev@suse.de>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "agraf@suse.de" <agraf@suse.de>

On 2015/2/3 20:34, Gonglei (Arei) wrote:

> From: Gonglei <arei.gonglei@huawei.com>
> 
> The reset logic can be done by both machine reset and
> boot handler. So we shouldn't return error when the boot
> handler callback don't be set in patch 1.
> 
> Patch 2 check boot order argument validation
> before vm running.
> 
> Patch 3 passing &error_abort instead of NULL.
> 
> v2 -> v1:
>  - add patch 2 suggested by Markus.
>  - rework patch 3. (Markus)
>  - add R-by in patch 1.
> 

Markus, any thoughts? Thanks.

Regards,
-Gonglei

> Gonglei (3):
>   bootdevice: remove the check about boot_set_handler
>   bootdevice: check boot order argument validation before vm running
>   bootdevice: add check in restore_boot_order()
> 
>  bootdevice.c | 12 ++++--------
>  vl.c         | 13 +++++++++++--
>  2 files changed, 15 insertions(+), 10 deletions(-)
>