From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: xuelin.shi-KZfg59tc24xl57MIdRCFDg@public.gmane.org
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v2] testpmd: fix port parsing in show port info command
Date: Fri, 06 Feb 2015 09:30:44 +0100 [thread overview]
Message-ID: <54D47BB4.9020005@6wind.com> (raw)
In-Reply-To: <1423186160-26035-1-git-send-email-xuelin.shi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Hi,
On 02/06/2015 02:29 AM, xuelin.shi-KZfg59tc24xl57MIdRCFDg@public.gmane.org wrote:
> From: Xuelin Shi <xuelin.shi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>
> the port number type should be consistent with librte_cmdline,
> else there is potential endian issue.
>
> Signed-off-by: Xuelin Shi <xuelin.shi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
> v2 change:
> change port type to uint8
> rephrase patch title
>
> app/test-pmd/cmdline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 590e427..d5f31f2 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -5584,7 +5584,7 @@ cmdline_parse_token_string_t cmd_showport_what =
> TOKEN_STRING_INITIALIZER(struct cmd_showport_result, what,
> "info#stats#xstats#fdir#stat_qmap");
> cmdline_parse_token_num_t cmd_showport_portnum =
> - TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, INT32);
> + TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, UINT8);
>
> cmdline_parse_inst_t cmd_showport = {
> .f = cmd_showport_parsed,
>
Acked-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
next prev parent reply other threads:[~2015-02-06 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 1:29 [PATCH v2] testpmd: fix port parsing in show port info command xuelin.shi-KZfg59tc24xl57MIdRCFDg
[not found] ` <1423186160-26035-1-git-send-email-xuelin.shi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-02-06 8:30 ` Olivier MATZ [this message]
[not found] ` <54D47BB4.9020005-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-02-15 15:46 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D47BB4.9020005@6wind.com \
--to=olivier.matz-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=xuelin.shi-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.