* [PATCH 0/3] update maintainers areas
@ 2015-02-04 22:23 Thomas Monjalon
[not found] ` <1423088604-29274-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 8+ messages in thread
From: Thomas Monjalon @ 2015-02-04 22:23 UTC (permalink / raw)
To: dev-VfR2kkLFssw
More files should be referenced in MAINTAINERS files:
- some (forgotten) docs can be co-maintained in doc and lib areas
- new ABI files
The script can now check for unknown files.
Thomas Monjalon (3):
maintainers: dispatch more doc
maintainers: add ABI versioning
scripts: check wrong patterns in maintainers file
MAINTAINERS | 9 +++++++++
scripts/check-maintainers.sh | 20 +++++++++++++++++++-
2 files changed, 28 insertions(+), 1 deletion(-)
--
2.2.2
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/3] maintainers: dispatch more doc
[not found] ` <1423088604-29274-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
@ 2015-02-04 22:23 ` Thomas Monjalon
[not found] ` <1423088604-29274-2-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-02-04 22:23 ` [PATCH 2/3] maintainers: add ABI versioning Thomas Monjalon
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Thomas Monjalon @ 2015-02-04 22:23 UTC (permalink / raw)
To: dev-VfR2kkLFssw
Documentation of build system, EAL and ring lib should be covered by
the maintainers of the respective areas.
Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
---
MAINTAINERS | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 12c7c16..f2b697e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -49,6 +49,10 @@ F: scripts/depdirs-rule.sh
F: scripts/gen-build-mk.sh
F: scripts/gen-config-h.sh
F: scripts/relpath.sh
+F: doc/build-sdk-quick.txt
+F: doc/guides/prog_guide/build_app.rst
+F: doc/guides/prog_guide/dev_kit_*
+F: doc/guides/prog_guide/ext_app_lib_make_help.rst
Environment Abstraction Layer
@@ -59,6 +63,7 @@ M: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
F: lib/librte_eal/common/*
F: lib/librte_eal/common/include/*
F: lib/librte_eal/common/include/generic/
+F: doc/guides/prog_guide/env_abstraction_layer.rst
F: app/test/test_alarm.c
F: app/test/test_atomic.c
F: app/test/test_byteorder.c
@@ -150,6 +155,7 @@ F: app/test/test_func_reentrancy.c
Ring queue
M: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
F: lib/librte_ring/
+F: doc/guides/prog_guide/ring_lib.rst
F: app/test/test_ring*
F: app/test/test_func_reentrancy.c
--
2.2.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/3] maintainers: add ABI versioning
[not found] ` <1423088604-29274-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-02-04 22:23 ` [PATCH 1/3] maintainers: dispatch more doc Thomas Monjalon
@ 2015-02-04 22:23 ` Thomas Monjalon
[not found] ` <1423088604-29274-3-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-02-04 22:23 ` [PATCH 3/3] scripts: check wrong patterns in maintainers file Thomas Monjalon
2015-02-09 14:21 ` [PATCH 0/3] update maintainers areas Thomas Monjalon
3 siblings, 1 reply; 8+ messages in thread
From: Thomas Monjalon @ 2015-02-04 22:23 UTC (permalink / raw)
To: dev-VfR2kkLFssw
Reference the new framework and policy for ABI versioning,
in the MAINTAINERS file.
Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
---
MAINTAINERS | 3 +++
1 file changed, 3 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index f2b697e..7c0047b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -54,6 +54,9 @@ F: doc/guides/prog_guide/build_app.rst
F: doc/guides/prog_guide/dev_kit_*
F: doc/guides/prog_guide/ext_app_lib_make_help.rst
+ABI versioning
+F: lib/librte_compat/
+F: doc/guides/rel_notes/abi.rst
Environment Abstraction Layer
-----------------------------
--
2.2.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/3] scripts: check wrong patterns in maintainers file
[not found] ` <1423088604-29274-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-02-04 22:23 ` [PATCH 1/3] maintainers: dispatch more doc Thomas Monjalon
2015-02-04 22:23 ` [PATCH 2/3] maintainers: add ABI versioning Thomas Monjalon
@ 2015-02-04 22:23 ` Thomas Monjalon
2015-02-09 14:21 ` [PATCH 0/3] update maintainers areas Thomas Monjalon
3 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2015-02-04 22:23 UTC (permalink / raw)
To: dev-VfR2kkLFssw
Each F or X pattern is checked and printed if there is no match
with a file in the repository.
The wildcard must be temporarily replaced to prevent from shell expansion.
Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
---
scripts/check-maintainers.sh | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/scripts/check-maintainers.sh b/scripts/check-maintainers.sh
index 2687cad..e62217e 100755
--- a/scripts/check-maintainers.sh
+++ b/scripts/check-maintainers.sh
@@ -88,6 +88,20 @@ parse_fx () # <index file>
done
}
+# Check patterns in F: and X:
+check_fx () # <index file>
+{
+ IFS='
+'
+ for line in $(sed -n 's,^[FX]: ,,p' $1 | tr '*' '#') ; do
+ line=$(printf "$line" | tr '#' '*')
+ match=$(files "$line")
+ if [ -z "$match" ] ; then
+ echo "$line"
+ fi
+ done
+}
+
# Add a line to a set of lines if it begins with right pattern
add_line_to_if () # <new line> <lines> <head pattern>
{
@@ -112,6 +126,10 @@ echo '# files not listed'
echo '##########'
aminusb "$all" "$listed"
-# TODO: check patterns that match nothing
+echo '##########'
+echo '# wrong patterns'
+echo '##########'
+check_fx MAINTAINERS
+
# TODO: check overlaps
# TODO: check orphan areas
--
2.2.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] maintainers: add ABI versioning
[not found] ` <1423088604-29274-3-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
@ 2015-02-05 1:39 ` Neil Horman
[not found] ` <20150205013917.GA8788-0o1r3XBGOEbbgkc5XkKeNuvMHUBZFtU3YPYVAmT7z5s@public.gmane.org>
0 siblings, 1 reply; 8+ messages in thread
From: Neil Horman @ 2015-02-05 1:39 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev-VfR2kkLFssw
On Wed, Feb 04, 2015 at 11:23:23PM +0100, Thomas Monjalon wrote:
> Reference the new framework and policy for ABI versioning,
> in the MAINTAINERS file.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> ---
> MAINTAINERS | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f2b697e..7c0047b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -54,6 +54,9 @@ F: doc/guides/prog_guide/build_app.rst
> F: doc/guides/prog_guide/dev_kit_*
> F: doc/guides/prog_guide/ext_app_lib_make_help.rst
>
> +ABI versioning
> +F: lib/librte_compat/
> +F: doc/guides/rel_notes/abi.rst
>
Feel free to add my name to this area of you feel its warranted.
Acked-by: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] maintainers: dispatch more doc
[not found] ` <1423088604-29274-2-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
@ 2015-02-06 8:55 ` Olivier MATZ
0 siblings, 0 replies; 8+ messages in thread
From: Olivier MATZ @ 2015-02-06 8:55 UTC (permalink / raw)
To: dev-VfR2kkLFssw
Hi Thomas,
On 02/04/2015 11:23 PM, Thomas Monjalon wrote:
> Documentation of build system, EAL and ring lib should be covered by
> the maintainers of the respective areas.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> ---
> MAINTAINERS | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 12c7c16..f2b697e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -49,6 +49,10 @@ F: scripts/depdirs-rule.sh
> F: scripts/gen-build-mk.sh
> F: scripts/gen-config-h.sh
> F: scripts/relpath.sh
> +F: doc/build-sdk-quick.txt
> +F: doc/guides/prog_guide/build_app.rst
> +F: doc/guides/prog_guide/dev_kit_*
> +F: doc/guides/prog_guide/ext_app_lib_make_help.rst
>
>
> Environment Abstraction Layer
> @@ -59,6 +63,7 @@ M: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> F: lib/librte_eal/common/*
> F: lib/librte_eal/common/include/*
> F: lib/librte_eal/common/include/generic/
> +F: doc/guides/prog_guide/env_abstraction_layer.rst
> F: app/test/test_alarm.c
> F: app/test/test_atomic.c
> F: app/test/test_byteorder.c
> @@ -150,6 +155,7 @@ F: app/test/test_func_reentrancy.c
> Ring queue
> M: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> F: lib/librte_ring/
> +F: doc/guides/prog_guide/ring_lib.rst
> F: app/test/test_ring*
> F: app/test/test_func_reentrancy.c
Acked-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] maintainers: add ABI versioning
[not found] ` <20150205013917.GA8788-0o1r3XBGOEbbgkc5XkKeNuvMHUBZFtU3YPYVAmT7z5s@public.gmane.org>
@ 2015-02-09 14:20 ` Thomas Monjalon
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2015-02-09 14:20 UTC (permalink / raw)
To: Neil Horman; +Cc: dev-VfR2kkLFssw
2015-02-04 20:39, Neil Horman:
> On Wed, Feb 04, 2015 at 11:23:23PM +0100, Thomas Monjalon wrote:
> > Reference the new framework and policy for ABI versioning,
> > in the MAINTAINERS file.
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> > ---
> > MAINTAINERS | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index f2b697e..7c0047b 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -54,6 +54,9 @@ F: doc/guides/prog_guide/build_app.rst
> > F: doc/guides/prog_guide/dev_kit_*
> > F: doc/guides/prog_guide/ext_app_lib_make_help.rst
> >
> > +ABI versioning
> > +F: lib/librte_compat/
> > +F: doc/guides/rel_notes/abi.rst
> >
> Feel free to add my name to this area of you feel its warranted.
> Acked-by: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
OK Neil, your name is added as ABI versioning maintainer.
Thanks
--
Thomas
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/3] update maintainers areas
[not found] ` <1423088604-29274-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
` (2 preceding siblings ...)
2015-02-04 22:23 ` [PATCH 3/3] scripts: check wrong patterns in maintainers file Thomas Monjalon
@ 2015-02-09 14:21 ` Thomas Monjalon
3 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2015-02-09 14:21 UTC (permalink / raw)
To: dev-VfR2kkLFssw
> More files should be referenced in MAINTAINERS files:
> - some (forgotten) docs can be co-maintained in doc and lib areas
> - new ABI files
> The script can now check for unknown files.
>
> Thomas Monjalon (3):
> maintainers: dispatch more doc
> maintainers: add ABI versioning
> scripts: check wrong patterns in maintainers file
Applied
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-02-09 14:21 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-04 22:23 [PATCH 0/3] update maintainers areas Thomas Monjalon
[not found] ` <1423088604-29274-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-02-04 22:23 ` [PATCH 1/3] maintainers: dispatch more doc Thomas Monjalon
[not found] ` <1423088604-29274-2-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-02-06 8:55 ` Olivier MATZ
2015-02-04 22:23 ` [PATCH 2/3] maintainers: add ABI versioning Thomas Monjalon
[not found] ` <1423088604-29274-3-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-02-05 1:39 ` Neil Horman
[not found] ` <20150205013917.GA8788-0o1r3XBGOEbbgkc5XkKeNuvMHUBZFtU3YPYVAmT7z5s@public.gmane.org>
2015-02-09 14:20 ` Thomas Monjalon
2015-02-04 22:23 ` [PATCH 3/3] scripts: check wrong patterns in maintainers file Thomas Monjalon
2015-02-09 14:21 ` [PATCH 0/3] update maintainers areas Thomas Monjalon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.