From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v3 1/3] genirq: Allow the irqchip state of an IRQ to be save/restored Date: Fri, 06 Feb 2015 09:02:09 +0000 Message-ID: <54D48311.7040305@arm.com> References: <1420653062-23361-1-git-send-email-marc.zyngier@arm.com> <1420653062-23361-2-git-send-email-marc.zyngier@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Bjorn Andersson , Thomas Gleixner Cc: Jason Cooper , Arnd Bergmann , Phong Vo , linux-arm-msm , Abhijeet Dharmapurikar , Stephen Boyd , "linux-kernel@vger.kernel.org" , Tin Huynh , "linux-arm-kernel@lists.infradead.org" , Bjorn Andersson , Toan Le , Linus Walleij , Y Vo List-Id: linux-arm-msm@vger.kernel.org On 05/02/15 23:33, Bjorn Andersson wrote: > On Wed, Jan 7, 2015 at 9:51 AM, Marc Zyngier wrote: >> There is a number of cases where a kernel subsystem may want to >> introspect the state of an interrupt at the irqchip level: >> >> - When a peripheral is shared between virtual machines, >> its interrupt state becomes part of the guest's state, >> and must be switched accordingly. KVM on arm/arm64 requires >> this for its guest-visible timer >> - Some GPIO controllers seem to require peeking into the >> interrupt controller they are connected to to report >> their internal state >> >> This seem to be a pattern that is common enough for the core code >> to try and support this without too many horrible hacks. Introduce >> a pair of accessors (irq_get_irqchip_state/irq_set_irqchip_state) >> to retrieve the bits that can be of interest to another subsystem: >> pending, active, and masked. >> >> - irq_get_irqchip_state returns the state of the interrupt according >> to a parameter set to IRQCHIP_STATE_PENDING, IRQCHIP_STATE_ACTIVE, >> IRQCHIP_STATE_MASKED or IRQCHIP_STATE_LINE_LEVEL. >> - irq_set_irqchip_state similarly sets the state of the interrupt. >> >> Reviewed-by: Bjorn Andersson >> Tested-by: Bjorn Andersson >> Signed-off-by: Marc Zyngier > > Any update on the status of this? > > I would like to be able to move ahead with the pinctrl driver for the > Qualcomm PM8921 pmic, that depends on this being in place. None so far. Thomas, do you have any comment on this one? Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Fri, 06 Feb 2015 09:02:09 +0000 Subject: [PATCH v3 1/3] genirq: Allow the irqchip state of an IRQ to be save/restored In-Reply-To: References: <1420653062-23361-1-git-send-email-marc.zyngier@arm.com> <1420653062-23361-2-git-send-email-marc.zyngier@arm.com> Message-ID: <54D48311.7040305@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/02/15 23:33, Bjorn Andersson wrote: > On Wed, Jan 7, 2015 at 9:51 AM, Marc Zyngier wrote: >> There is a number of cases where a kernel subsystem may want to >> introspect the state of an interrupt at the irqchip level: >> >> - When a peripheral is shared between virtual machines, >> its interrupt state becomes part of the guest's state, >> and must be switched accordingly. KVM on arm/arm64 requires >> this for its guest-visible timer >> - Some GPIO controllers seem to require peeking into the >> interrupt controller they are connected to to report >> their internal state >> >> This seem to be a pattern that is common enough for the core code >> to try and support this without too many horrible hacks. Introduce >> a pair of accessors (irq_get_irqchip_state/irq_set_irqchip_state) >> to retrieve the bits that can be of interest to another subsystem: >> pending, active, and masked. >> >> - irq_get_irqchip_state returns the state of the interrupt according >> to a parameter set to IRQCHIP_STATE_PENDING, IRQCHIP_STATE_ACTIVE, >> IRQCHIP_STATE_MASKED or IRQCHIP_STATE_LINE_LEVEL. >> - irq_set_irqchip_state similarly sets the state of the interrupt. >> >> Reviewed-by: Bjorn Andersson >> Tested-by: Bjorn Andersson >> Signed-off-by: Marc Zyngier > > Any update on the status of this? > > I would like to be able to move ahead with the pinctrl driver for the > Qualcomm PM8921 pmic, that depends on this being in place. None so far. Thomas, do you have any comment on this one? Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754986AbbBFJLW (ORCPT ); Fri, 6 Feb 2015 04:11:22 -0500 Received: from foss.arm.com ([217.140.101.70]:39913 "EHLO usa-sjc-mx-foss1.foss.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751978AbbBFJLQ (ORCPT ); Fri, 6 Feb 2015 04:11:16 -0500 X-Greylist: delayed 541 seconds by postgrey-1.27 at vger.kernel.org; Fri, 06 Feb 2015 04:11:16 EST Message-ID: <54D48311.7040305@arm.com> Date: Fri, 06 Feb 2015 09:02:09 +0000 From: Marc Zyngier Organization: ARM Ltd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: Bjorn Andersson , Thomas Gleixner CC: Abhijeet Dharmapurikar , Stephen Boyd , Phong Vo , Linus Walleij , Tin Huynh , Y Vo , Toan Le , Jason Cooper , Arnd Bergmann , Bjorn Andersson , linux-arm-msm , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 1/3] genirq: Allow the irqchip state of an IRQ to be save/restored References: <1420653062-23361-1-git-send-email-marc.zyngier@arm.com> <1420653062-23361-2-git-send-email-marc.zyngier@arm.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/02/15 23:33, Bjorn Andersson wrote: > On Wed, Jan 7, 2015 at 9:51 AM, Marc Zyngier wrote: >> There is a number of cases where a kernel subsystem may want to >> introspect the state of an interrupt at the irqchip level: >> >> - When a peripheral is shared between virtual machines, >> its interrupt state becomes part of the guest's state, >> and must be switched accordingly. KVM on arm/arm64 requires >> this for its guest-visible timer >> - Some GPIO controllers seem to require peeking into the >> interrupt controller they are connected to to report >> their internal state >> >> This seem to be a pattern that is common enough for the core code >> to try and support this without too many horrible hacks. Introduce >> a pair of accessors (irq_get_irqchip_state/irq_set_irqchip_state) >> to retrieve the bits that can be of interest to another subsystem: >> pending, active, and masked. >> >> - irq_get_irqchip_state returns the state of the interrupt according >> to a parameter set to IRQCHIP_STATE_PENDING, IRQCHIP_STATE_ACTIVE, >> IRQCHIP_STATE_MASKED or IRQCHIP_STATE_LINE_LEVEL. >> - irq_set_irqchip_state similarly sets the state of the interrupt. >> >> Reviewed-by: Bjorn Andersson >> Tested-by: Bjorn Andersson >> Signed-off-by: Marc Zyngier > > Any update on the status of this? > > I would like to be able to move ahead with the pinctrl driver for the > Qualcomm PM8921 pmic, that depends on this being in place. None so far. Thomas, do you have any comment on this one? Thanks, M. -- Jazz is not dead. It just smells funny...