Reason for extra struct kvm_run parameter in MMIO handling?

[Andre Przywara <andre.przywara@arm.com>]

Hi,

while reworking the ARM vGIC emulation layer to use the kvm_io_bus
framework, I wonder why the whole KVM MMIO handling always passes the
pointer to struct kvm_run along with the struct kvm_vcpu pointer.
As kvm_run is a member of kvm_vcpu, the vcpu alone should be sufficient,
right?
Also I see the very top of the call chain is effectively:
kvm_arch_vcpu_ioctl_run(vcpu, vcpu->run);

So is that just legacy code still lingering around from the dawn of time
and nobody dared to rework this or is there a particular reason for
doing so?

I am asking because I lack the kvm_run pointer in the MMIO handler, so I
just use vcpu->run and I wonder if there are potential issues in doing so.

Cheers,
Andre.