From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754871AbbBFRgr (ORCPT ); Fri, 6 Feb 2015 12:36:47 -0500 Received: from smtp.codeaurora.org ([198.145.11.231]:44236 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752809AbbBFRgq (ORCPT ); Fri, 6 Feb 2015 12:36:46 -0500 Message-ID: <54D4FBAC.8000605@codeaurora.org> Date: Fri, 06 Feb 2015 09:36:44 -0800 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Sylwester Nawrocki , Mike Turquette , Tomeu Vizoso CC: linux-kernel@vger.kernel.org, Alban Browaeys , Beata Michalska Subject: Re: [PATCH v2] clkdev: Always allocate a struct clk and call __clk_get() w/ CCF References: <1423186850-32547-1-git-send-email-sboyd@codeaurora.org> <54D49E0D.8090809@samsung.com> In-Reply-To: <54D49E0D.8090809@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/06/15 02:57, Sylwester Nawrocki wrote: > > As a side note, IMHO recent changes made the code much harder to follow, > e.g. by using 'clk' local variable name interchangeably for 'struct clk' > and 'struct clk_core' types and by using same field name in different data > structures, like 'child_node'. I guess the changes were limited to make > the diff smaller, nevertheless it seems we ended up with something rather > illegible. Yes it was to reduce diff. I plan to do the rename once the dust settles. > > Tested-by: Sylwester Nawrocki > > Thanks. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project