From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 1/4] stubs for xsavec support Date: Fri, 06 Feb 2015 20:40:38 +0100 Message-ID: <54D518B6.9070101@siemens.com> References: <1420713159-25947-1-git-send-email-pbonzini@redhat.com> <1420713159-25947-2-git-send-email-pbonzini@redhat.com> <54CF2160.1010305@siemens.com> <54CF3DCD.6010607@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit To: Paolo Bonzini , kvm@vger.kernel.org Return-path: Received: from david.siemens.de ([192.35.17.14]:52720 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754573AbbBFTkv (ORCPT ); Fri, 6 Feb 2015 14:40:51 -0500 In-Reply-To: <54CF3DCD.6010607@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2015-02-02 10:05, Paolo Bonzini wrote: > > > On 02/02/2015 08:04, Jan Kiszka wrote: >>>> +#if X86_FEATURE_XSAVEOPT < 10 * 32 >>>> +#undef X86_FEATURE_XSAVEOPT >>>> +#endif >>>> +#define X86_FEATURE_XSAVEOPT (10*32+0) /* XSAVEOPT instruction */ >> This causes redefinition warnings if the condition is not met. Was the >> plan to put the define before the #endif? > > The plan was to match the kernel's definition, which however has a space: > > #define X86_FEATURE_XSAVEOPT (10*32+ 0) > > But putting the define before the #endif also works. Finally got my buildbot working again: There are some open issues, maybe you can have a look at http://buildbot.kiszka.org/kvm-kmod/waterfall, next branch. At least the 3.17 thing requires fixing but may require more than a #define. Thanks, Jan -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux