All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Zhao <mzhao-82A4bShDkBpJQxFrfMEhiVaTQe2KTcn/@public.gmane.org>
To: dev-VfR2kkLFssw@public.gmane.org
Subject: "virtual" C++ keyword used in rte_devargs.h and causes compilation error in C++
Date: Fri, 06 Feb 2015 23:24:15 -0800	[thread overview]
Message-ID: <54D5BD9F.7000902@luminatewireless.com> (raw)

The code is in rte_devargs.h:

rte_devargs.h:

                /** Used if type is RTE_DEVTYPE_VIRTUAL. */
                struct {
                        /** Driver name. */
                        char drv_name[32];
                } virtual;
        };

Which caused clang compiler to report error when this file is included
by a cpp file, the error message is:

In file included from net/dpdk/testing/base-test.cc:3:
In file included from net/dpdk/testing/base-test.h:8:
third-party/dpdk/lib/librte_eal/common/include/rte_devargs.h:89:5:
error: 'virtual' can only appear on non-static
      member functions
                } virtual;
                  ^

I think we should try to pick another name for this field. I would
suggest calling it "vdev" instead, or I'll be happy to take another name
if someone comes with a different idea.

Thanks!
Ming

             reply	other threads:[~2015-02-07  7:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-07  7:24 Ming Zhao [this message]
     [not found] ` <54D5BD9F.7000902-82A4bShDkBpJQxFrfMEhiVaTQe2KTcn/@public.gmane.org>
2015-02-07 20:23   ` "virtual" C++ keyword used in rte_devargs.h and causes compilation error in C++ Neil Horman
     [not found]     ` <20150207202349.GA7064-0o1r3XBGOEbbgkc5XkKeNuvMHUBZFtU3YPYVAmT7z5s@public.gmane.org>
2015-02-08  6:33       ` Ming Zhao
     [not found]         ` <54D70343.6060502-82A4bShDkBpJQxFrfMEhiVaTQe2KTcn/@public.gmane.org>
2015-02-08  7:31           ` Ariel Rodriguez
     [not found]             ` <CADoa0baQnWJTUhJRWh13UJCcqZ_JEpd5mwzVdfPeeehJ+fLYdg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-08 13:53               ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D5BD9F.7000902@luminatewireless.com \
    --to=mzhao-82a4bshdkbpjqxfrfmehivatqe2ktcn/@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.