Re: [meta-fsl-arm][PATCH] linux-imx: Disable imx6sl code when not needed (3.10.17)

[Nikolay Dimitrov <picmaster@mail.bg>]

Hi Otavio,

On 02/06/2015 05:51 PM, Otavio Salvador wrote:
> Hello,
>
> On Fri, Feb 6, 2015 at 1:20 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
>> Hi Eric,
>>
>> On 02/06/2015 04:48 PM, Eric Bénard wrote:
>>>
>>> Hi Nikolay,
>>>
>>> Le Fri,  6 Feb 2015 16:29:36 +0200,
>>> picmaster@mail.bg a écrit :
>>>
>>>> From: Nikolay Dimitrov <picmaster@mail.bg>
>>>>
>>>>
>>>> Signed-off-by: Nikolay Dimitrov <picmaster@mail.bg>
>>>> ---
>>>>    ...Disable-imx6sl-specific-code-when-imx6sl-.patch |  419
>>>> ++++++++++++++++++++
>>>>    1 file changed, 419 insertions(+)
>>>>    create mode 100644
>>>> recipes-kernel/linux/linux-imx-3.10.17/0002-ARM-imx6sl-Disable-imx6sl-specific-code-when-imx6sl-.patch
>>>>
>>>> diff --git
>>>> a/recipes-kernel/linux/linux-imx-3.10.17/0002-ARM-imx6sl-Disable-imx6sl-specific-code-when-imx6sl-.patch
>>>> b/recipes-kernel/linux/linux-imx-3.10.17/0002-ARM-imx6sl-Disable-imx6sl-specific-code-when-imx6sl-.patch
>>>> new file mode 100644
>>>> index 0000000..3255352
>>>> --- /dev/null
>>>> +++
>>>> b/recipes-kernel/linux/linux-imx-3.10.17/0002-ARM-imx6sl-Disable-imx6sl-specific-code-when-imx6sl-.patch
>>>> @@ -0,0 +1,419 @@
>>>> +From 351f605f08b7fb808ed3fdcb57f61db478be2c59 Mon Sep 17 00:00:00 2001
>>>> +From: Nikolay Dimitrov <picmaster@mail.bg>
>>>> +Date: Fri, 6 Feb 2015 14:37:50 +0200
>>>> +Subject: [PATCH] ARM: imx6sl: Disable imx6sl-specific code when imx6sl
>>>> SOC
>>>> + support is disabled
>>>> +
>>>
>>> why is that needed ?
>>
>>
>> The patch purpose is to handle enabling/disabling CONFIG_SOC_IMX6SL.
>> Until now it wasn't possible due to some hard-coded pieces here and
>> there (build fails when imx6sl support is disabled).
>
> Add this in the patch itself.
>
> Also, add this on the recipe and do a proper commit log for it as well.
>
> This helps to get this reviewed, merged and ease the handling of it in future.

Thanks for your comments. V2 is on the way.

> Did you check if 3.10.53 also needs this?

Nope, as I can't test it easily. If someone volunteers to test the
patch there, I can submit it.

Regards,
Nikolay