From: Jonathan Cameron <jic23@kernel.org>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Hartmut Knaack <knaack.h@gmx.de>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Josef Gajdusek <atx@atalax.net>,
Teodora Baluta <teodora.baluta@intel.com>,
Marek Belisko <marek@goldelico.com>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: magnetometer: hmc5843_core: Change type in printf format string
Date: Sun, 08 Feb 2015 12:04:34 +0000 [thread overview]
Message-ID: <54D750D2.9080601@kernel.org> (raw)
In-Reply-To: <1422397297-9206-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On 27/01/15 22:21, Rickard Strandqvist wrote:
> Wrong type in printf format string, requires 'int'
> but the argument type is 'unsigned int'
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
This one is fixed to I'm afraid. Very bad luck on timing as 2 weeks ago you'd have
been first to post a patch for it.
> ---
> drivers/staging/iio/magnetometer/hmc5843_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/magnetometer/hmc5843_core.c b/drivers/staging/iio/magnetometer/hmc5843_core.c
> index fd171d8..cd049bb 100644
> --- a/drivers/staging/iio/magnetometer/hmc5843_core.c
> +++ b/drivers/staging/iio/magnetometer/hmc5843_core.c
> @@ -217,7 +217,7 @@ static ssize_t hmc5843_show_measurement_configuration(struct device *dev,
> return ret;
> val &= HMC5843_MEAS_CONF_MASK;
>
> - return sprintf(buf, "%d\n", val);
> + return sprintf(buf, "%u\n", val);
> }
>
> static ssize_t hmc5843_set_measurement_configuration(struct device *dev,
>
prev parent reply other threads:[~2015-02-08 12:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 22:21 [PATCH] staging: iio: magnetometer: hmc5843_core: Change type in printf format string Rickard Strandqvist
2015-02-08 12:04 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D750D2.9080601@kernel.org \
--to=jic23@kernel.org \
--cc=atx@atalax.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek@goldelico.com \
--cc=pmeerw@pmeerw.net \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=teodora.baluta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.