From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755998AbbBHQDz (ORCPT ); Sun, 8 Feb 2015 11:03:55 -0500 Received: from www.linutronix.de ([62.245.132.108]:41756 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752218AbbBHQDx (ORCPT ); Sun, 8 Feb 2015 11:03:53 -0500 Message-ID: <54D788E5.306@linutronix.de> Date: Sun, 08 Feb 2015 17:03:49 +0100 From: Sebastian Andrzej Siewior User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: David Dueck , linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org CC: balbi@ti.com, linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: phy: am335x-control: check return value of bus_find_device References: <1423409370-4769-1-git-send-email-davidcdueck@googlemail.com> In-Reply-To: <1423409370-4769-1-git-send-email-davidcdueck@googlemail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/08/2015 04:29 PM, David Dueck wrote: > This fixes a potential null pointer dereference. > > Signed-off-by: David Dueck Acked-by: Sebastian Andrzej Siewior Fixes: d4332013919a ("driver core: dev_get_drvdata: Don't check for NULL dev") Greg, this is a regression since d43320139 ("driver core: dev_get_drvdata: Don't check for NULL dev"). I didn't check for NULL after bus_find_device() because I knew that dev_get_drvdata() will do it. > --- > drivers/usb/phy/phy-am335x-control.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/phy/phy-am335x-control.c b/drivers/usb/phy/phy-am335x-control.c > index 403fab7..7b3035f 100644 > --- a/drivers/usb/phy/phy-am335x-control.c > +++ b/drivers/usb/phy/phy-am335x-control.c > @@ -126,6 +126,9 @@ struct phy_control *am335x_get_phy_control(struct device *dev) > return NULL; > > dev = bus_find_device(&platform_bus_type, NULL, node, match); > + if (!dev) > + return NULL; > + > ctrl_usb = dev_get_drvdata(dev) > if (!ctrl_usb) > return NULL; > Sebastian