From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bo Shen Subject: Re: [PATCH 2/3] ASoC: atmel_ssc_dai: refactor the startup and shutdown Date: Mon, 9 Feb 2015 08:52:52 +0800 Message-ID: <54D804E4.1000202@atmel.com> References: <1422610724-7222-1-git-send-email-voice.shen@atmel.com> <1422610724-7222-3-git-send-email-voice.shen@atmel.com> <20150130132047.GO26617@finisterre.sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150130132047.GO26617@finisterre.sirena.org.uk> Sender: linux-sound-owner@vger.kernel.org To: Mark Brown Cc: nicolas.ferre@atmel.com, Songjun.Wu@atmel.com, linux-sound@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org Hi Mark, On 01/30/2015 09:20 PM, Mark Brown wrote: > On Fri, Jan 30, 2015 at 05:38:43PM +0800, Bo Shen wrote: >> In startup function, enable ssc clock and in shutdown function, >> disable clock. And also remove disable ssc in shutdown function, >> as ssc is disabled in prepare function. > > Applied, thanks. You probably want to convert to clk_prepare_enable() > too but that's a separate thing. OK, thanks, I will check that. As now, we prepare clock in ssc driver, then enable it in dai driver. Best Regards, Bo Shen From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bo Shen Date: Mon, 09 Feb 2015 00:52:52 +0000 Subject: Re: [PATCH 2/3] ASoC: atmel_ssc_dai: refactor the startup and shutdown Message-Id: <54D804E4.1000202@atmel.com> List-Id: References: <1422610724-7222-1-git-send-email-voice.shen@atmel.com> <1422610724-7222-3-git-send-email-voice.shen@atmel.com> <20150130132047.GO26617@finisterre.sirena.org.uk> In-Reply-To: <20150130132047.GO26617@finisterre.sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mark Brown Cc: nicolas.ferre@atmel.com, Songjun.Wu@atmel.com, linux-sound@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Hi Mark, On 01/30/2015 09:20 PM, Mark Brown wrote: > On Fri, Jan 30, 2015 at 05:38:43PM +0800, Bo Shen wrote: >> In startup function, enable ssc clock and in shutdown function, >> disable clock. And also remove disable ssc in shutdown function, >> as ssc is disabled in prepare function. > > Applied, thanks. You probably want to convert to clk_prepare_enable() > too but that's a separate thing. OK, thanks, I will check that. As now, we prepare clock in ssc driver, then enable it in dai driver. Best Regards, Bo Shen From mboxrd@z Thu Jan 1 00:00:00 1970 From: voice.shen@atmel.com (Bo Shen) Date: Mon, 9 Feb 2015 08:52:52 +0800 Subject: [PATCH 2/3] ASoC: atmel_ssc_dai: refactor the startup and shutdown In-Reply-To: <20150130132047.GO26617@finisterre.sirena.org.uk> References: <1422610724-7222-1-git-send-email-voice.shen@atmel.com> <1422610724-7222-3-git-send-email-voice.shen@atmel.com> <20150130132047.GO26617@finisterre.sirena.org.uk> Message-ID: <54D804E4.1000202@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mark, On 01/30/2015 09:20 PM, Mark Brown wrote: > On Fri, Jan 30, 2015 at 05:38:43PM +0800, Bo Shen wrote: >> In startup function, enable ssc clock and in shutdown function, >> disable clock. And also remove disable ssc in shutdown function, >> as ssc is disabled in prepare function. > > Applied, thanks. You probably want to convert to clk_prepare_enable() > too but that's a separate thing. OK, thanks, I will check that. As now, we prepare clock in ssc driver, then enable it in dai driver. Best Regards, Bo Shen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759023AbbBIAxJ (ORCPT ); Sun, 8 Feb 2015 19:53:09 -0500 Received: from nasmtp01.atmel.com ([192.199.1.245]:51190 "EHLO DVREDG01.corp.atmel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753071AbbBIAxH (ORCPT ); Sun, 8 Feb 2015 19:53:07 -0500 Message-ID: <54D804E4.1000202@atmel.com> Date: Mon, 9 Feb 2015 08:52:52 +0800 From: Bo Shen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Mark Brown CC: , , , , , Subject: Re: [PATCH 2/3] ASoC: atmel_ssc_dai: refactor the startup and shutdown References: <1422610724-7222-1-git-send-email-voice.shen@atmel.com> <1422610724-7222-3-git-send-email-voice.shen@atmel.com> <20150130132047.GO26617@finisterre.sirena.org.uk> In-Reply-To: <20150130132047.GO26617@finisterre.sirena.org.uk> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.168.5.13] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 01/30/2015 09:20 PM, Mark Brown wrote: > On Fri, Jan 30, 2015 at 05:38:43PM +0800, Bo Shen wrote: >> In startup function, enable ssc clock and in shutdown function, >> disable clock. And also remove disable ssc in shutdown function, >> as ssc is disabled in prepare function. > > Applied, thanks. You probably want to convert to clk_prepare_enable() > too but that's a separate thing. OK, thanks, I will check that. As now, we prepare clock in ssc driver, then enable it in dai driver. Best Regards, Bo Shen