diff for duplicates of <54D83A2B.3070601@roeck-us.net> diff --git a/a/1.txt b/N1/1.txt index 4924a7e..143fa6f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -57,7 +57,7 @@ On 02/08/2015 01:36 PM, Lukasz Majewski wrote: >>> + ret = of_property_count_elems_of_size(np, "cooling-levels", >>> + sizeof(u32)); >>> + ->>> + if (ret == -EINVAL) { +>>> + if (ret = -EINVAL) { >>> + dev_err(dev, "Property 'cooling-levels' not >>> found\n"); >>> + return 0; @@ -109,7 +109,13 @@ You don't return an error, you return 0, at least in some circumstances. > broken property. > It returns -ENOSYS if DT is not configured, which is still unacceptable. -And, again, if ret == 0 is an error, you should return an error code, +And, again, if ret = 0 is an error, you should return an error code, not display an error message and return 0. Guenter + + +_______________________________________________ +lm-sensors mailing list +lm-sensors@lm-sensors.org +http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index df53846..22c282e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,8 +4,8 @@ "ref\020150206183657.GB25410@roeck-us.net\0" "ref\020150208223640.2bcab3f4@jawa\0" "From\0Guenter Roeck <linux@roeck-us.net>\0" - "Subject\0Re: [PATCH v3 7/8] hwmon: pwm-fan: Read PWM FAN configuration from device tree\0" - "Date\0Sun, 08 Feb 2015 20:40:11 -0800\0" + "Subject\0Re: [lm-sensors] [PATCH v3 7/8] hwmon: pwm-fan: Read PWM FAN configuration from device tree\0" + "Date\0Mon, 09 Feb 2015 04:40:11 +0000\0" "To\0Lukasz Majewski <l.majewski@majess.pl>\0" "Cc\0Lukasz Majewski <l.majewski@samsung.com>" Eduardo Valentin <edubezval@gmail.com> @@ -82,7 +82,7 @@ ">>> +\tret = of_property_count_elems_of_size(np, \"cooling-levels\",\n" ">>> +\t\t\t\t\t sizeof(u32));\n" ">>> +\n" - ">>> +\tif (ret == -EINVAL) {\n" + ">>> +\tif (ret = -EINVAL) {\n" ">>> +\t\tdev_err(dev, \"Property 'cooling-levels' not\n" ">>> found\\n\");\n" ">>> +\t\treturn 0;\n" @@ -134,9 +134,15 @@ "> broken property.\n" ">\n" "It returns -ENOSYS if DT is not configured, which is still unacceptable.\n" - "And, again, if ret == 0 is an error, you should return an error code,\n" + "And, again, if ret = 0 is an error, you should return an error code,\n" "not display an error message and return 0.\n" "\n" - Guenter + "Guenter\n" + "\n" + "\n" + "_______________________________________________\n" + "lm-sensors mailing list\n" + "lm-sensors@lm-sensors.org\n" + http://lists.lm-sensors.org/mailman/listinfo/lm-sensors -a8fa3e77b5ddd9b0f7414b4ecf36a4b07133737d30d8d7d8c58fa370061047ee +087a04f496c930780c8868a5600d87d621aef2593dc2debd1655388da380d859
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.