Re: [PATCH v2] Documentation: leds: Add description of LED Flash class extension

[Jacek Anaszewski <j.anaszewski@samsung.com>]

On 02/06/2015 07:48 PM, Bryan Wu wrote:
> On Thu, Feb 5, 2015 at 12:42 AM, Jacek Anaszewski
> <j.anaszewski@samsung.com> wrote:
>> The documentation being added contains overall description of the
>> LED Flash Class and the related sysfs attributes.
>>
>> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
>> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
>> Cc: Bryan Wu <cooloney@gmail.com>
>> Cc: Richard Purdie <rpurdie@rpsys.net>
>> ---
>
> Jacek, I lost the discussion here. Did you change something since V1 patch?
>
> Pavel, Is this version OK for you?

I changed the instruction on how to proceed with flash faults handling
in LED Flash class drivers (the part after listing possible flash
faults, as it is exposed below. There hasn't been any opinion on this
expressed yet, though.


>> +               * led-over-temperature - the temperature of the LED has exceeded
>> +                       its allowed upper limit
>> +
>> +               Flash faults should be read in the strobe_set callback, right
>> +               after the instruction initiating the strobe. If a flash LED
>> +               device provides an instruction for clearing the faults, then,
>> +               in case there were any faults read, it should be also executed
>> +               in the callback.
>> --
>> 1.7.9.5
>>
>


-- 
Best Regards,
Jacek Anaszewski