From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [PATCH 0/2] ARM: omap2+: omap_hwmod: Fix false lockdep warning Date: Mon, 9 Feb 2015 10:27:32 +0200 Message-ID: <54D86F74.7070703@ti.com> References: <1423226916-18804-1-git-send-email-peter.ujfalusi@ti.com> <20150206141346.GP21418@twins.programming.kicks-ass.net> <54D4E64C.7060208@ti.com> <20150206183205.GS21418@twins.programming.kicks-ass.net> <54D5154F.8080208@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:42585 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752414AbbBII2H (ORCPT ); Mon, 9 Feb 2015 03:28:07 -0500 In-Reply-To: <54D5154F.8080208@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Peter Zijlstra Cc: Tony Lindgren , paul@pwsan.com, linux-omap@vger.kernel.org, mingo@redhat.com, linux-kernel@vger.kernel.org, balbi@ti.com, linux-arm-kernel@lists.infradead.org, Tero Kristo On 02/06/2015 09:26 PM, Peter Ujfalusi wrote: >> Yeah, I've never really bothered with data too much, its a debug >> feature. So lock_class_key is 8 bytes, and strictly speaking you cou= ld >> union them over other fields, all we really need is unique addresses= , we >> don't actually use the storage. >=20 > True. our omap2plus defconfig does not have LOCKDEP enabled so it sho= uld not > add anything to the data when running default kernel. > I'll test the lockdep_set_class() method you suggested on Monday (not > tomorrow), but still as first thing. > If it is working as expected I'll send a patch with you as author. With omap2plus_defconfig my build produces (vmlinux size): Base: 99905522 with my series: 99908385 (base + 2863) with Peter Zijlstra's patch: 99910625 (base + 5103) The reason for this is that we will only have struct lock_class_key { }; in case of !CONFIG_LOCKDEP. On ARM however CONFIG_LOCKDEP is enabled by default, while the CONFIG_DEBUG_LOCKDEP is disabled. So it does add more data to our default omap2plus config. Tony: do you have preference on the way we fix this issue? As I recall there is a plan to remove the hwmod static database and mov= e it or generate it from DT? Not sure when and how this will be done, but will = it affect the lockdep_set_class() way? --=20 P=E9ter -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: peter.ujfalusi@ti.com (Peter Ujfalusi) Date: Mon, 9 Feb 2015 10:27:32 +0200 Subject: [PATCH 0/2] ARM: omap2+: omap_hwmod: Fix false lockdep warning In-Reply-To: <54D5154F.8080208@ti.com> References: <1423226916-18804-1-git-send-email-peter.ujfalusi@ti.com> <20150206141346.GP21418@twins.programming.kicks-ass.net> <54D4E64C.7060208@ti.com> <20150206183205.GS21418@twins.programming.kicks-ass.net> <54D5154F.8080208@ti.com> Message-ID: <54D86F74.7070703@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/06/2015 09:26 PM, Peter Ujfalusi wrote: >> Yeah, I've never really bothered with data too much, its a debug >> feature. So lock_class_key is 8 bytes, and strictly speaking you could >> union them over other fields, all we really need is unique addresses, we >> don't actually use the storage. > > True. our omap2plus defconfig does not have LOCKDEP enabled so it should not > add anything to the data when running default kernel. > I'll test the lockdep_set_class() method you suggested on Monday (not > tomorrow), but still as first thing. > If it is working as expected I'll send a patch with you as author. With omap2plus_defconfig my build produces (vmlinux size): Base: 99905522 with my series: 99908385 (base + 2863) with Peter Zijlstra's patch: 99910625 (base + 5103) The reason for this is that we will only have struct lock_class_key { }; in case of !CONFIG_LOCKDEP. On ARM however CONFIG_LOCKDEP is enabled by default, while the CONFIG_DEBUG_LOCKDEP is disabled. So it does add more data to our default omap2plus config. Tony: do you have preference on the way we fix this issue? As I recall there is a plan to remove the hwmod static database and move it or generate it from DT? Not sure when and how this will be done, but will it affect the lockdep_set_class() way? -- P?ter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759536AbbBII2J (ORCPT ); Mon, 9 Feb 2015 03:28:09 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:42585 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752414AbbBII2H (ORCPT ); Mon, 9 Feb 2015 03:28:07 -0500 Message-ID: <54D86F74.7070703@ti.com> Date: Mon, 9 Feb 2015 10:27:32 +0200 From: Peter Ujfalusi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Peter Zijlstra CC: Tony Lindgren , , , , , , , Tero Kristo Subject: Re: [PATCH 0/2] ARM: omap2+: omap_hwmod: Fix false lockdep warning References: <1423226916-18804-1-git-send-email-peter.ujfalusi@ti.com> <20150206141346.GP21418@twins.programming.kicks-ass.net> <54D4E64C.7060208@ti.com> <20150206183205.GS21418@twins.programming.kicks-ass.net> <54D5154F.8080208@ti.com> In-Reply-To: <54D5154F.8080208@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/06/2015 09:26 PM, Peter Ujfalusi wrote: >> Yeah, I've never really bothered with data too much, its a debug >> feature. So lock_class_key is 8 bytes, and strictly speaking you could >> union them over other fields, all we really need is unique addresses, we >> don't actually use the storage. > > True. our omap2plus defconfig does not have LOCKDEP enabled so it should not > add anything to the data when running default kernel. > I'll test the lockdep_set_class() method you suggested on Monday (not > tomorrow), but still as first thing. > If it is working as expected I'll send a patch with you as author. With omap2plus_defconfig my build produces (vmlinux size): Base: 99905522 with my series: 99908385 (base + 2863) with Peter Zijlstra's patch: 99910625 (base + 5103) The reason for this is that we will only have struct lock_class_key { }; in case of !CONFIG_LOCKDEP. On ARM however CONFIG_LOCKDEP is enabled by default, while the CONFIG_DEBUG_LOCKDEP is disabled. So it does add more data to our default omap2plus config. Tony: do you have preference on the way we fix this issue? As I recall there is a plan to remove the hwmod static database and move it or generate it from DT? Not sure when and how this will be done, but will it affect the lockdep_set_class() way? -- Péter