All of lore.kernel.org
 help / color / mirror / Atom feed
From: Claudio Fontana <claudio.fontana@huawei.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: [Qemu-devel] --disable-vnc broken?
Date: Mon, 9 Feb 2015 11:14:53 +0100	[thread overview]
Message-ID: <54D8889D.1090906@huawei.com> (raw)

Hello,

is some #ifdef CONFIG_VNC missing in the latest vnc changes in mainline QEMU?

I ask because configuring with --disable-vnc and then building now gets me:

../qmp-marshal.o: In function `qmp_marshal_input_query_vnc_servers':
qemu/qmp-marshal.c:2899: undefined reference to `qmp_query_vnc_servers'

while before it was working fine.

Configuring without --disable-vnc and then building works.

I bisected this and got the following.

Thanks,

Claudio

df887684603a4b3b0c623090a6b419dc70f22c32 is the first bad commit
commit df887684603a4b3b0c623090a6b419dc70f22c32
Author: Gerd Hoffmann <kraxel@redhat.com>
Date:   Wed Dec 17 15:49:44 2014 +0100

    monitor: add query-vnc-servers command

    Add new query vnc qmp command, for the lack of better ideas just name it
    "query-vnc-servers".  Changes over query-vnc:

     * It returns a list of vnc servers, so multiple vnc server instances
       are covered.
     * Each vnc server returns a list of server sockets.  Followup patch
       will use that to also report websockets.  In case we add support for
       multiple server sockets server sockets (to better support ipv4+ipv6
       dualstack) we can add them to the list too.

    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

             reply	other threads:[~2015-02-09 10:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09 10:14 Claudio Fontana [this message]
2015-02-09 10:25 ` [Qemu-devel] --disable-vnc broken? Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D8889D.1090906@huawei.com \
    --to=claudio.fontana@huawei.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.