From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Inki Dae <inki.dae@samsung.com>
Cc: devicetree@vger.kernel.org, airlied@linux.ie,
dri-devel@lists.freedesktop.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
a.hajda@samsung.com
Subject: Re: [PATCH 1/4] drm/exynos: dsim: fix to control mipi phy register
Date: Mon, 09 Feb 2015 14:46:43 +0100 [thread overview]
Message-ID: <54D8BA43.9030609@samsung.com> (raw)
In-Reply-To: <54D8A55F.8020001@samsung.com>
On 09/02/15 13:17, Inki Dae wrote:
>> Instead I just added syscon support to the PHY layer, it's not perfect
>> > but fixes the issue for both DSI and CSI and doesn't strip the PHY layer
>> > which could potentially be useful.
>
> Ah, Right. I didn't check your patch set. Your way is a better idea than
> my one. With this, we don't need to change device drivers, MIPI DSI and CSI.
>
> Then, what is the meaning that it's not perfect?
What I didn't like is that there are at least 3 mutexes on the phy_power_on/
phy_power_off path (PHY core, PHY driver, regmap) and there is another level
of indirection after introducing the regmap. I guess it's nothing serious
though. And BTW the syscon could be converted to use spinlock rather than
a mutex, since in our case behind the PMU syscon is always a memory mapped
region.
--
Regards,
Sylwester
next prev parent reply other threads:[~2015-02-09 13:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-07 11:53 [PATCH 0/4] drm/exynos: use syscon framework to enable mipi phy Inki Dae
2015-02-07 11:53 ` [PATCH 1/4] drm/exynos: dsim: fix to control mipi phy register Inki Dae
2015-02-09 10:57 ` Sylwester Nawrocki
2015-02-09 12:17 ` Inki Dae
2015-02-09 13:46 ` Sylwester Nawrocki [this message]
2015-02-07 11:53 ` [PATCH 2/4] ARM: dts: exynos4: use pmureg device node to enable mipi phy Inki Dae
2015-02-07 11:53 ` [PATCH 3/4] ARM: dts: exynos3250: " Inki Dae
2015-02-07 11:53 ` [PATCH 4/4] ARM: dts: exynos5420: " Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D8BA43.9030609@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=inki.dae@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.