All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
	Peter Maydell <peter.maydell@linaro.org>
Cc: Andy Whitcroft <apw@canonical.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH] checkpatch: port fix from kernel "## is not a valid modifier"
Date: Mon, 09 Feb 2015 15:31:54 +0100	[thread overview]
Message-ID: <54D8C4DA.4080403@redhat.com> (raw)
In-Reply-To: <1423484293-46903-1-git-send-email-borntraeger@de.ibm.com>



On 09/02/2015 13:18, Christian Borntraeger wrote:
> From: Andy Whitcroft <apw@canonical.com>
> 
> checkpatch currently loops on fpu/softfloat.c
> Turns out this is fixed in the Linux version of checkpatch.
> 
> So this is a port of Andy Whitcrofts fix from Linux,
> Original commit was commit 89a883530fe7 ("checkpatch: ## is not a
> valid modifier")

I think you need to send it as a toplevel patch for Peter to pick it up.

Paolo

> Cc: Andy Whitcroft <apw@canonical.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  scripts/checkpatch.pl | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 5df61f9..8635f4c 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1061,7 +1061,9 @@ sub possible {
>  			case|
>  			else|
>  			asm|__asm__|
> -			do
> +			do|
> +			\#|
> +			\#\#|
>  		)(?:\s|$)|
>  		^(?:typedef|struct|enum)\b
>  	    )}x;
> 

  reply	other threads:[~2015-02-09 14:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-02 20:22 [Qemu-devel] This patch hunk will hang scripts/checkpatch.pl Peter Maydell
2015-02-03 10:03 ` Dr. David Alan Gilbert
2015-02-09 12:18 ` [Qemu-devel] [PATCH] checkpatch: port fix from kernel "## is not a valid modifier" Christian Borntraeger
2015-02-09 14:31   ` Paolo Bonzini [this message]
2015-02-09 15:08     ` Christian Borntraeger
2015-02-09 15:59       ` Don Slutz
  -- strict thread matches above, loose matches on Subject: below --
2015-02-09 19:43 Christian Borntraeger
2015-02-09 22:54 ` Peter Maydell
2015-02-10  8:07   ` Christian Borntraeger
2015-02-10  9:40   ` Christian Borntraeger
2015-02-10 12:01     ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D8C4DA.4080403@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=apw@canonical.com \
    --cc=borntraeger@de.ibm.com \
    --cc=dgilbert@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.