From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43711)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1YKqkA-0008BC-6U
	for qemu-devel@nongnu.org; Mon, 09 Feb 2015 10:59:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1YKqk6-0003e0-6A
	for qemu-devel@nongnu.org; Mon, 09 Feb 2015 10:59:26 -0500
Received: from omzsmtpe04.verizonbusiness.com ([199.249.25.207]:22342)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1YKqk6-0003bz-0f
	for qemu-devel@nongnu.org; Mon, 09 Feb 2015 10:59:22 -0500
From: Don Slutz <dslutz@verizon.com>
Message-ID: <54D8D955.7030601@terremark.com>
Date: Mon, 09 Feb 2015 10:59:17 -0500
MIME-Version: 1.0
References: <CAFEAcA9dvehzeL1T+BT3N+_GJtGoL4ig_opv7rVT-0eJekLAvg@mail.gmail.com>	<1423484293-46903-1-git-send-email-borntraeger@de.ibm.com>	<54D8C4DA.4080403@redhat.com>
	<54D8CD51.5080308@de.ibm.com>
In-Reply-To: <54D8CD51.5080308@de.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] checkpatch: port fix from kernel "## is
 not a valid modifier"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christian Borntraeger <borntraeger@de.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, Peter Maydell <peter.maydell@linaro.org>
Cc: Andy Whitcroft <apw@canonical.com>, qemu-devel <qemu-devel@nongnu.org>, dgilbert@redhat.com

On 02/09/15 10:08, Christian Borntraeger wrote:
> Am 09.02.2015 um 15:31 schrieb Paolo Bonzini:
>>
>>
>> On 09/02/2015 13:18, Christian Borntraeger wrote:
>>> From: Andy Whitcroft <apw@canonical.com>
>>>
>>> checkpatch currently loops on fpu/softfloat.c
>>> Turns out this is fixed in the Linux version of checkpatch.
>>>
>>> So this is a port of Andy Whitcrofts fix from Linux,
>>> Original commit was commit 89a883530fe7 ("checkpatch: ## is not a
>>> valid modifier")
>>
>> I think you need to send it as a toplevel patch for Peter to pick it up.
> 
> What do you mean? This patch is on top of qemu/master - if I dont messed up.
> 

The patch email headers:

...
Message-ID: <1423484293-46903-1-git-send-email-borntraeger@de.ibm.com>
X-Mailer: git-send-email 1.9.3
In-Reply-To:
<CAFEAcA9dvehzeL1T+BT3N+_GJtGoL4ig_opv7rVT-0eJekLAvg@mail.gmail.com>
References:
<CAFEAcA9dvehzeL1T+BT3N+_GJtGoL4ig_opv7rVT-0eJekLAvg@mail.gmail.com>
...

Say that it is a reply, not a new email thread.

  -Don Slutz


> Christian
>>
>> Paolo
>>
>>> Cc: Andy Whitcroft <apw@canonical.com>
>>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>>> ---
>>>  scripts/checkpatch.pl | 4 +++-
>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>>> index 5df61f9..8635f4c 100755
>>> --- a/scripts/checkpatch.pl
>>> +++ b/scripts/checkpatch.pl
>>> @@ -1061,7 +1061,9 @@ sub possible {
>>>  			case|
>>>  			else|
>>>  			asm|__asm__|
>>> -			do
>>> +			do|
>>> +			\#|
>>> +			\#\#|
>>>  		)(?:\s|$)|
>>>  		^(?:typedef|struct|enum)\b
>>>  	    )}x;
>>>
>>
> 
>