All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Desfossez <jdesfossez@efficios.com>
To: Matthew Khouzam <matthew.khouzam@ericsson.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: diamon-discuss@lists.linuxfoundation.org,
	lttng-dev@lists.lttng.org,
	tracecompass developer discussions <tracecompass-dev@eclipse.org>
Subject: Re: [diamon-discuss] Parsing external datasources in trace compass for regions of interest in a trace
Date: Mon, 09 Feb 2015 13:49:39 -0500	[thread overview]
Message-ID: <54D90143.5040401@efficios.com> (raw)
In-Reply-To: <54D8FF55.7040602@ericsson.com>

On 15-02-09 01:41 PM, Matthew Khouzam wrote:
> Great feedback. I think for a first draft, this will work out swimmingly.
> 
> Right now, I was actually finding the first group of [], splitting with
> "," [1], then for every timestamp, creating a bookmark.
That's a good first start I think.

> 
> so [12:20:23 , 12:23:22] some range
> would give
> bookmark 1-> 12:20:23 -> some range start
> bookmark 2-> 12:23:22 -> some range end
I'm not sure exactly how clear it will be with overlapping ranges in the
TraceCompass list of bookmarks, but I guess it will be handled in a next
phase.

> 
> and
> [22:33:44 ] [key : value] [name = value] [id -> ref ] ...
> would parse as everything after the timestamp would be read as a string.
> 
> text [22:33:44] text2
> would discard text.
> 
> Is this ok?
Yes, let's start with that. As we discussed, if we need to output
differently from the analyses, we will make the changes.

> [1]note, it will not work with https://github.com/lttng/lttng-analyses
> where dash is used.
Oh if you are referring to the "Work in progress" section, you are
right, don't worry about this, it is a prototype and cannot even be used
from the scripts in the master branch. When this is ready it will use
the standard format.

Thanks,

Julien

> 
> On 15-02-06 06:03 PM, Julien Desfossez wrote:
>>
>> On 15-02-06 05:22 PM, Mathieu Desnoyers wrote:
>>> ----- Original Message -----
>>>> From: "Matthew Khouzam" <matthew.khouzam@ericsson.com>
>>>> To: "tracecompass developer discussions" <tracecompass-dev@eclipse.org>, diamon-discuss@lists.linuxfoundation.org,
>>>> lttng-dev@lists.lttng.org
>>>> Sent: Friday, February 6, 2015 5:13:42 PM
>>>> Subject: [diamon-discuss] Parsing external datasources in trace compass for regions of interest in a trace
>>>>
>>>> Hello,
>>>>
>>>> I am right now looking getting external datasources to supply
>>>> information for a trace, like a region of interest.
>>>>
>>>> Background: we can run an analysis on a trace manually, in python, excel
>>>> or what have you and come up with something interesting, like: around
>>>> 12:30pm something happened to a trace. Let's dig deeper with tracecompass.
>>>>
>>>> To make this work: we need to find a way to import the data, so we
>>>> should agree on a standard data standard. I personally like the LTTng
>>>> analysis outputs so I am picking that for now. :)
>>>>
>>>> Here are some formats that could be acceptable as regions of interest
>>>>  * [2015-01-15 12:18:37.216484041, 2015-01-15 12:18:53.821580313] name
>>>>  * [2015-01-15 12:18:37.216484041, 2015-01-15 12:18:53.821580313] name
>>>> boookmark
>>>>  * [ 2015-01-15 12:18:37.216484041] name boookmark
>>>>  * [12:18:37.216484041] name boookmark
>>>>  * [ 12:18:37.216484041, 12:18:53.821580313] name boookmark
>>>>  * [ 2014-12-12 17:29:43.802588035] name with space
>>>>  * [ 2014-12-12 17:29:43] irrational title
>>>>  * [17:29:43.802588035] rational title
>>>>  * [ 17:29:43] test test test
>>>>  * [17:29:43,17:29:44] thing
>>>>  * [12:18:37.216484041   ] (no text)
>>>>
>>>> When there is one timestamp, we will create one bookmark.
>>>> When there is a range, we would create two bookmarks in a given trace,
>>>> the first one being appended with " start" the second with " end"
>>>>
>>>> This should allow tracecompass to marginally benefit from the lttng
>>>> analyses that are looking pretty nice, and later perhaps from tcp
>>>> analyses from tshark and syslog stuff.
>>>>
>>>> Does anyone have an objection to this way of working?
>>> Do you intend on supporting timestamps that appear elsewhere than
>>> the beginning of lines ? Do you consider all text at the right of
>>> the timestamp or timestamp range to be part of the naming of the
>>> region of interest linked to the timestamp/timestamp range ?
>>>
>>> Julien, did we want to reserve [] for only timestamp range or
>>> we also want them for single timestamps ?
>> Right now the [] are only valid with time ranges (they are not accepted
>> with --begin and --end). I don't mind allowing the brackets for all
>> timestamps (like in dmesg), we still have the "," to identify if it's a
>> range or not.
>> But for convenience, they will remain optional for --begin and --end.
>>
>> We just have to keep in mind, that [32,64] could be a range of
>> values/frequency and not necessarily timestamps.
>>
>> Julien
> 

  parent reply	other threads:[~2015-02-09 18:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-06 22:13 [diamon-discuss] Parsing external datasources in trace compass for regions of interest in a trace Matthew Khouzam
2015-02-06 22:22 ` Mathieu Desnoyers
2015-02-06 22:22 ` Mathieu Desnoyers
2015-02-06 23:03   ` Julien Desfossez
2015-02-06 23:03   ` Julien Desfossez
2015-02-09 18:41     ` Matthew Khouzam
2015-02-09 18:41     ` Matthew Khouzam
2015-02-09 18:49       ` Julien Desfossez
2015-02-09 18:49       ` Julien Desfossez [this message]
2015-02-10 14:04         ` Bernd Hufmann
2015-02-10 14:04         ` Bernd Hufmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D90143.5040401@efficios.com \
    --to=jdesfossez@efficios.com \
    --cc=diamon-discuss@lists.linuxfoundation.org \
    --cc=lttng-dev@lists.lttng.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=matthew.khouzam@ericsson.com \
    --cc=tracecompass-dev@eclipse.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.