From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH V3 0/2] add support for pmic_arb v2 and correct framework Date: Mon, 09 Feb 2015 15:08:58 -0800 Message-ID: <54D93E0A.9000703@codeaurora.org> References: <1423522272-24472-1-git-send-email-gavidov@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1423522272-24472-1-git-send-email-gavidov@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Gilad Avidov , sdharia@codeaurora.org, mlocke@codeaurora.org, linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, iivanov@mm-sol.com, galak@codeaurora.org, agross@codeaurora.org List-Id: linux-arm-msm@vger.kernel.org On 02/09/15 14:51, Gilad Avidov wrote: > pmic_arb v2 has no support for spmi non-data commands and thus > returns -EOPNOTSUPP on .cmd callback. This causes a failure in > spmi_drv_probe() which sends a wakeup command to the slave before > probing its driver. This patchset removes the wakeup from > spmi_drv_probe() since the spmi spec stipulates that a slaves > default state is active and doesn't need a wakeup. The spec also seems to stipulate that SPMI masters shall support all SPMI command sequences. > Gilad Avidov (2): > spmi: remove wakeup command before slave probe > spmi: pmic_arb: add support for hw version 2 > > .../bindings/spmi/qcom,spmi-pmic-arb.txt | 6 +- > drivers/spmi/spmi-pmic-arb.c | 312 +++++++++++++++++---- > drivers/spmi/spmi.c | 9 +- > 3 files changed, 263 insertions(+), 64 deletions(-) > Can you please include a patchset changelog here? What changed between v2 and v3? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project