From: Paolo Bonzini <pbonzini@redhat.com>
To: David Matlack <dmatlack@google.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kvm list <kvm@vger.kernel.org>,
riel@redhat.com, Marcelo Tosatti <mtosatti@redhat.com>,
rkrcmar@redhat.com
Subject: Re: [PATCH 1/2] KVM: x86: extract guest running logic from __vcpu_run
Date: Tue, 10 Feb 2015 09:18:10 +0100 [thread overview]
Message-ID: <54D9BEC2.5020500@redhat.com> (raw)
In-Reply-To: <CALzav=e+_s7GUn4RoW73X-BZiZL0Ez3qaFFrnCRLiczdX83ngA@mail.gmail.com>
On 09/02/2015 23:44, David Matlack wrote:
>> >
>> > +static inline int __vcpu_run(struct kvm *kvm, struct kvm_vcpu *vcpu)
> Kind of confusing function body given the name. Maybe put
>
> if (vcpu->arch.mp_state == KVM_MP_STATE_RUNNABLE &&
> !vcpu->arch.apf.halted)
> return vcpu_enter_guest(vcpu);
>
> back in vcpu_run and rename this function? vcpu_wait?
Yeah, vcpu_wait or vcpu_block (since it calls kvm_vcpu_block) sound good.
Paolo
next prev parent reply other threads:[~2015-02-10 8:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 12:16 [PATCH 0/2] KVM: APIC timer latency improvement Paolo Bonzini
2015-02-06 12:16 ` [PATCH 1/2] KVM: x86: extract guest running logic from __vcpu_run Paolo Bonzini
2015-02-09 22:44 ` David Matlack
2015-02-10 8:18 ` Paolo Bonzini [this message]
2015-02-09 23:32 ` Rik van Riel
2015-02-06 12:16 ` [PATCH 2/2] KVM: x86: optimize delivery of TSC deadline timer interrupt Paolo Bonzini
2015-02-06 20:51 ` Marcelo Tosatti
2015-02-07 20:33 ` Paolo Bonzini
2015-02-10 19:30 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D9BEC2.5020500@redhat.com \
--to=pbonzini@redhat.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=riel@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.