From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] Fix crash during ACL deletion in acl max entry check in gfs2_set_acl()
Date: Tue, 10 Feb 2015 10:44:28 +0000 [thread overview]
Message-ID: <54D9E10C.1080903@redhat.com> (raw)
In-Reply-To: <1423504384-47404-1-git-send-email-aweits@rit.edu>
Hi,
Now in the -nmw git tree. Thanks,
Steve.
On 09/02/15 17:53, Andrew Elble wrote:
> Fixes: e01580bf9e ("gfs2: use generic posix ACL infrastructure")
> Reported-by: Eric Meddaugh <etmsys@rit.edu>
> Tested-by: Eric Meddaugh <etmsys@rit.edu>
> Signed-off-by: Andrew Elble <aweits@rit.edu>
> ---
> fs/gfs2/acl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c
> index 3088e2a..7b31430 100644
> --- a/fs/gfs2/acl.c
> +++ b/fs/gfs2/acl.c
> @@ -73,7 +73,7 @@ int gfs2_set_acl(struct inode *inode, struct posix_acl *acl, int type)
>
> BUG_ON(name == NULL);
>
> - if (acl->a_count > GFS2_ACL_MAX_ENTRIES(GFS2_SB(inode)))
> + if (acl && acl->a_count > GFS2_ACL_MAX_ENTRIES(GFS2_SB(inode)))
> return -E2BIG;
>
> if (type == ACL_TYPE_ACCESS) {
prev parent reply other threads:[~2015-02-10 10:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 17:53 [Cluster-devel] [PATCH] Fix crash during ACL deletion in acl max entry check in gfs2_set_acl() Andrew Elble
2015-02-10 10:44 ` Steven Whitehouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D9E10C.1080903@redhat.com \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.