From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v3 0/7] Display IO topology when PXM data is available (plus some cleanup) Date: Tue, 10 Feb 2015 11:08:30 +0000 Message-ID: <54D9E6AE.7030609@citrix.com> References: <1423512275-6531-1-git-send-email-boris.ostrovsky@oracle.com> <54D9D4FB020000780005E78B@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54D9D4FB020000780005E78B@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, port-xen@netbsd.org, stefano.stabellini@eu.citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, Jan Beulich , keir@xen.org, ufimtseva@gmail.com List-Id: xen-devel@lists.xenproject.org On 10/02/15 08:52, Jan Beulich wrote: >>>> On 09.02.15 at 21:04, wrote: >> * Make changes to xen_sysctl_numainfo, similar to those made to >> xen_sysctl_topologyinfo. (Q: I kept both sets of changes in the same >> patch #3 to avoid bumping interface version twice. Perhaps it's better >> to split it into two?) > There's no need to bump it more than once between releases. > Hence yes - splitting would be better. I will wait until patch 3 is split to do an in-depth review, but one thing you need to fix is that the INVALID_$FOO identifiers need a XEN_ prefix to put them in the same namespace as the other identifiers. ~Andrew