From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 1/1] ARM: dts: Use more descriptive names for Exynos5420 PDs Date: Tue, 10 Feb 2015 15:21:05 +0300 Message-ID: <54D9F7B1.3030106@cogentembedded.com> References: <1423244258-24314-1-git-send-email-javier.martinez@collabora.co.uk> <54D51170.10903@cogentembedded.com> <54D52905.6040100@collabora.co.uk> <54D9F1A4.1000908@cogentembedded.com> <1423570670.6241.2.camel@AMDC1943> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1423570670.6241.2.camel@AMDC1943> Sender: linux-kernel-owner@vger.kernel.org To: Krzysztof Kozlowski Cc: Javier Martinez Canillas , Kukjin Kim , Andrzej Hajda , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marek Szyprowski List-Id: linux-samsung-soc@vger.kernel.org On 2/10/2015 3:17 PM, Krzysztof Kozlowski wrote: >>> Additionally (on Arndale Octa): >>> $ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary >>> domain status slaves >>> /device runtime status >>> ---------------------------------------------------------------------- >>> power-domain on >>> /devices/platform/amba/3880000.adma suspended >>> power-domain off >>> power-domain off >>> power-domain off >>> power-domain off >>> power-domain off >>> This really is not helpful. From the power domain debugfs code it is >>> complicated to extract of_node of power domain. >> You shouldn't need it. >>> It is easier to print >>> the name of power domain. But wait... all names are the same! :) So >>> why do we have the name in the first place? >> I'm not sure why the full platform device names aren't printed -- they >> should all be different. > This debugfs code iterates over list of generic_pm_domains (gpd_list). I > cannot find function for translating from genpd to its platform device > so only genpd->name can be printed. Then why power domains aren't just named with the platform device names? > Best regards, > Krzysztof WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Tue, 10 Feb 2015 15:21:05 +0300 Subject: [PATCH 1/1] ARM: dts: Use more descriptive names for Exynos5420 PDs In-Reply-To: <1423570670.6241.2.camel@AMDC1943> References: <1423244258-24314-1-git-send-email-javier.martinez@collabora.co.uk> <54D51170.10903@cogentembedded.com> <54D52905.6040100@collabora.co.uk> <54D9F1A4.1000908@cogentembedded.com> <1423570670.6241.2.camel@AMDC1943> Message-ID: <54D9F7B1.3030106@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2/10/2015 3:17 PM, Krzysztof Kozlowski wrote: >>> Additionally (on Arndale Octa): >>> $ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary >>> domain status slaves >>> /device runtime status >>> ---------------------------------------------------------------------- >>> power-domain on >>> /devices/platform/amba/3880000.adma suspended >>> power-domain off >>> power-domain off >>> power-domain off >>> power-domain off >>> power-domain off >>> This really is not helpful. From the power domain debugfs code it is >>> complicated to extract of_node of power domain. >> You shouldn't need it. >>> It is easier to print >>> the name of power domain. But wait... all names are the same! :) So >>> why do we have the name in the first place? >> I'm not sure why the full platform device names aren't printed -- they >> should all be different. > This debugfs code iterates over list of generic_pm_domains (gpd_list). I > cannot find function for translating from genpd to its platform device > so only genpd->name can be printed. Then why power domains aren't just named with the platform device names? > Best regards, > Krzysztof WBR, Sergei