From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err()
Date: Tue, 10 Feb 2015 17:44:59 +0100 [thread overview]
Message-ID: <54DA358B.9060509@redhat.com> (raw)
In-Reply-To: <1423586055-4932-2-git-send-email-armbru@redhat.com>
On 10/02/2015 17:34, Markus Armbruster wrote:
> I've typed error_report("%s", error_get_pretty(ERR)) too many times
> already, and I've fixed too many instances of qerror_report_err(ERR)
> to error_report("%s", error_get_pretty(ERR)) as well. Capture the
> pattern in a convenience function.
>
> Since it's almost invariably followed by error_free(), stuff that into
> the convenience function as well.
>
> Put it to use with this Coccinelle semantic patch:
For your "no good deed goes unpunished" record, can you prepare a Wiki
page on how to use Coccinelle? My attempts always saw it confused by
qemu/queue.h macros.
Paolo
next prev parent reply other threads:[~2015-02-10 16:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 16:34 [Qemu-devel] [PATCH 0/9] Clean up around error_get_pretty(), qerror_report_err() Markus Armbruster
2015-02-10 16:34 ` [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err() Markus Armbruster
2015-02-10 16:44 ` Paolo Bonzini [this message]
2015-02-10 22:04 ` Eduardo Habkost
2015-02-11 10:17 ` Paolo Bonzini
2015-02-11 13:13 ` [Qemu-devel] Coccinelle semantic patches (was Re: [PATCH 1/9] error: New convenience function error_report_err()) Eduardo Habkost
2015-02-11 12:47 ` [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err() Markus Armbruster
2015-02-10 17:20 ` Eric Blake
2015-02-11 10:04 ` Kevin Wolf
2015-02-11 12:24 ` Markus Armbruster
2015-02-10 16:34 ` [Qemu-devel] [PATCH 2/9] monitor: Clean up around monitor_handle_fd_param() Markus Armbruster
2015-02-10 21:09 ` Eric Blake
2015-02-10 16:34 ` [Qemu-devel] [PATCH 3/9] monitor: Avoid qerror_report_err() outside QMP command handlers Markus Armbruster
2015-02-10 16:34 ` [Qemu-devel] [PATCH 4/9] net: " Markus Armbruster
2015-02-10 16:34 ` [Qemu-devel] [PATCH 5/9] numa: " Markus Armbruster
2015-02-10 16:34 ` [Qemu-devel] [PATCH 6/9] tpm: " Markus Armbruster
2015-02-10 16:34 ` [Qemu-devel] [PATCH 7/9] vl: " Markus Armbruster
2015-02-10 16:34 ` [Qemu-devel] [PATCH 8/9] qemu-img: " Markus Armbruster
2015-02-10 16:34 ` [Qemu-devel] [PATCH 9/9] qemu-char: " Markus Armbruster
2015-02-11 15:28 ` [Qemu-devel] [PATCH 0/9] Clean up around error_get_pretty(), qerror_report_err() Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DA358B.9060509@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.