[PATCH] dbus: Move generic DBus paths to header file

[PATCH] dbus: Move generic DBus paths to header file

[Jukka Rissanen]

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

DBus defines moved to header file so that they can be used
by other source files.
---
 ell/dbus.c | 5 -----
 ell/dbus.h | 4 ++++
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/ell/dbus.c b/ell/dbus.c
index 4c4ba2d..26456ac 100644
--- a/ell/dbus.c
+++ b/ell/dbus.c
@@ -45,11 +45,6 @@
 
 #define DEFAULT_SYSTEM_BUS_ADDRESS "unix:path=/var/run/dbus/system_bus_socket"
 
-#define DBUS_SERVICE_DBUS	"org.freedesktop.DBus"
-
-#define DBUS_PATH_DBUS		"/org/freedesktop/DBus"
-
-#define DBUS_INTERFACE_DBUS		"org.freedesktop.DBus"
 #define DBUS_INTERFACE_INTROSPECTABLE	"org.freedesktop.DBus.Introspectable"
 #define DBUS_INTERFACE_PROPERTIES	"org.freedesktop.DBus.Properties"
 
diff --git a/ell/dbus.h b/ell/dbus.h
index a6ad109..7622b47 100644
--- a/ell/dbus.h
+++ b/ell/dbus.h
@@ -32,6 +32,10 @@
 extern "C" {
 #endif
 
+#define DBUS_SERVICE_DBUS	"org.freedesktop.DBus"
+#define DBUS_PATH_DBUS		"/org/freedesktop/DBus"
+#define DBUS_INTERFACE_DBUS	"org.freedesktop.DBus"
+
 enum l_dbus_bus {
 	L_DBUS_SYSTEM_BUS,
 	L_DBUS_SESSION_BUS,
-- 
1.8.3.1

Re: [PATCH] dbus: Move generic DBus paths to header file

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

Hi Jukka,

On 02/10/2015 08:52 AM, Jukka Rissanen wrote:
> DBus defines moved to header file so that they can be used
> by other source files.

What other source files?  Care to give me a bit more context?

Also, I prefer we localize all the DBus Classic stuff to ell/dbus.c as 
much as possible.

> ---
>   ell/dbus.c | 5 -----
>   ell/dbus.h | 4 ++++
>   2 files changed, 4 insertions(+), 5 deletions(-)
>

Regards,
-Denis