From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLHr7-0003zL-Vk for qemu-devel@nongnu.org; Tue, 10 Feb 2015 15:56:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLHr1-0007N2-V2 for qemu-devel@nongnu.org; Tue, 10 Feb 2015 15:56:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53670) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLHr1-0007Mi-OA for qemu-devel@nongnu.org; Tue, 10 Feb 2015 15:56:19 -0500 Message-ID: <54DA706D.5080503@redhat.com> Date: Tue, 10 Feb 2015 15:56:13 -0500 From: Max Reitz MIME-Version: 1.0 References: <1423555201-32429-1-git-send-email-chenxg@linux.vnet.ibm.com> <1423555201-32429-3-git-send-email-chenxg@linux.vnet.ibm.com> In-Reply-To: <1423555201-32429-3-git-send-email-chenxg@linux.vnet.ibm.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC v5 2/5] qemu-iotests: run qemu with -nodefaults and fix 067, 071, 087 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guang Chen , qemu-devel@nongnu.org Cc: kwolf@redhat.com, mimu@linux.vnet.ibm.com, armbru@redhat.com On 2015-02-10 at 02:59, Xiao Guang Chen wrote: > This patch fixes an io test suite issue that was introduced with the > commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only > a single "stdio" character device'. The option supresses the creation of > default devices such as the floopy and cdrom. Output files for test case > 067, 071 and 087 need to be updated to accommodate this change. > Use virtio-blk instead of virtio-blk-pci as the device driver for test case > 067. For virtio-blk-pci is the same with virtio-blk as device driver but > other platform such as s390 may not recognize the virtio-blk-pci. > > Reviewed-by: Michael Mueller > Signed-off-by: Xiao Guang Chen > --- > tests/qemu-iotests/067 | 8 +- > tests/qemu-iotests/067.out | 266 +-------------------------------------- > tests/qemu-iotests/071.out | 4 - > tests/qemu-iotests/087.out | 12 -- > tests/qemu-iotests/common | 1 + > tests/qemu-iotests/common.config | 2 +- > tests/qemu-iotests/common.qemu | 2 +- > 7 files changed, 8 insertions(+), 287 deletions(-) I'm sorry I didn't notice earlier, but test 081 needs the same treatment. Apart from this, this patch looks good to me, though. Max