All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonyoung Shim <jy0922.shim@samsung.com>
To: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
	linux-samsung-soc@vger.kernel.org
Cc: robclark@freedesktop.org, dri-devel@lists.freedesktop.org,
	m.szyprowski@samsung.com
Subject: Re: [PATCH 04/15] tests/exynos: disable the G2D userptr/blend test
Date: Wed, 11 Feb 2015 10:11:43 +0900	[thread overview]
Message-ID: <54DAAC4F.5020906@samsung.com> (raw)
In-Reply-To: <1422971645-30621-5-git-send-email-tjakobi@math.uni-bielefeld.de>

Hi,

On 02/03/2015 10:53 PM, Tobias Jakobi wrote:
> The blend test uses the userptr functionality of exynos-drm, which
> is currently not safe to use. If the kernel hasn't been build with
> exynos-iommu support, then the blend test is going to produce (kernel)
> memory corruption, eventually leading to a system crash.
> 
> Disable the test for now, until the kernel code has been sanitized.
> 
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> ---
>  tests/exynos/exynos_fimg2d_test.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/exynos/exynos_fimg2d_test.c b/tests/exynos/exynos_fimg2d_test.c
> index aa140e5..48dfe97 100644
> --- a/tests/exynos/exynos_fimg2d_test.c
> +++ b/tests/exynos/exynos_fimg2d_test.c
> @@ -788,11 +788,13 @@ int main(int argc, char **argv)
>  
>  	getchar();
>  
> +#if 0

How about add some comments about why need disable?

Thanks.

>  	ret  = test_case.blend(dev, src, bo, G2D_IMGBUF_USERPTR);
>  	if (ret < 0)
>  		fprintf(stderr, "failed to test blend operation.\n");
>  
>  	getchar();
> +#endif
>  
>  err_free_src:
>  	if (src)
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-02-11  1:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-03 13:53 [libdrm] improvements to userspace exynos component Tobias Jakobi
2015-02-03 13:53 ` [PATCH 01/15] tests/exynos: fimg2d: add a checkerboard test Tobias Jakobi
2015-02-03 13:53 ` [PATCH 02/15] exynos: replace G2D_DOUBLE_TO_FIXED macro with function Tobias Jakobi
2015-02-03 13:53 ` [PATCH 03/15] tests/exynos: fix typos and change wording Tobias Jakobi
2015-02-03 13:53 ` [PATCH 04/15] tests/exynos: disable the G2D userptr/blend test Tobias Jakobi
2015-02-11  1:11   ` Joonyoung Shim [this message]
2015-02-11  1:39     ` Tobias Jakobi
2015-02-11  1:47       ` Joonyoung Shim
2015-02-03 13:53 ` [PATCH 05/15] exynos: add g2d_scale_and_blend Tobias Jakobi
2015-02-03 13:53 ` [PATCH 06/15] tests/exynos: introduce wait_for_user_input Tobias Jakobi
2015-02-03 13:53 ` [PATCH 07/15] exynos: honor the repeat mode in g2d_copy_with_scale Tobias Jakobi
2015-02-03 13:53 ` [PATCH 08/15] exynos: introduce g2d_add_base_addr helper function Tobias Jakobi
2015-02-03 13:53 ` [PATCH 09/15] exynos: use structure initialization instead of memset Tobias Jakobi
2015-02-03 13:54 ` [PATCH 10/15] tests/exynos: improve error handling Tobias Jakobi
2015-02-03 13:54 ` [PATCH 11/15] exynos: add exynos prefix to fimg2d header Tobias Jakobi
2015-02-03 13:54 ` [PATCH 12/15] exynos: add fimg2d header to common includes Tobias Jakobi
2015-02-03 13:54 ` [PATCH 13/15] exynos: fimg2d: fix comment for G2D_COEFF_MODE_GB_COLOR Tobias Jakobi
2015-02-03 13:54 ` [PATCH 14/15] exynos: fimg2d: unify register style Tobias Jakobi
2015-02-03 13:54 ` [PATCH 15/15] exynos: fimg2d: introduce G2D_OP_INTERPOLATE Tobias Jakobi
2015-02-11  1:11 ` [libdrm] improvements to userspace exynos component Joonyoung Shim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DAAC4F.5020906@samsung.com \
    --to=jy0922.shim@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=robclark@freedesktop.org \
    --cc=tjakobi@math.uni-bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.