From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH RFC 26/35] arm : acpi read mmio tables from
	uefi
Date: Wed, 11 Feb 2015 17:14:34 +0800
Message-ID: <54DB1D7A.40402@linaro.org>
References: <1423058539-26403-1-git-send-email-parth.dixit@linaro.org>
	<1423058539-26403-27-git-send-email-parth.dixit@linaro.org>
	<alpine.DEB.2.02.1502051628170.29696@kaball.uk.xensource.com>
	<54D40D14.8060108@linaro.org>
	<alpine.DEB.2.02.1502061412520.29696@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1502061412520.29696@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: ian.campbell@citrix.com, tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, jbeulich@suse.com, Parth Dixit <parth.dixit@linaro.org>, christoffer.dall@linaro.org
List-Id: xen-devel@lists.xenproject.org

Hi Stefano,

On 06/02/2015 22:17, Stefano Stabellini wrote:
> On Fri, 6 Feb 2015, Julien Grall wrote:
>> On 06/02/2015 00:34, Stefano Stabellini wrote:
>>>> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
>>>> index 93c8a8a..930746b 100644
>>>> --- a/xen/arch/arm/setup.c
>>>> +++ b/xen/arch/arm/setup.c
>>>> @@ -50,6 +50,7 @@
>>>>    #include <asm-arm/cputype.h>
>>>>
>>>>    struct bootinfo __initdata bootinfo;
>>>> +struct meminfo __initdata acpi_mmio;
>>>>
>>>>    struct cpuinfo_arm __read_mostly boot_cpu_data;
>>>>
>>>> diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h
>>>> index ba5a67d..5ea9ed6 100644
>>>> --- a/xen/include/asm-arm/setup.h
>>>> +++ b/xen/include/asm-arm/setup.h
>>>> @@ -46,6 +46,7 @@ struct bootinfo {
>>>>    };
>>>>
>>>>    extern struct bootinfo bootinfo;
>>>> +extern struct meminfo acpi_mmio;
>>>
>>> It might make sense to reuse bootinfo.mem.
>>
>> Do you mean by extending the meminfo structure with a flags indicating if it's
>> a RAM or MMIO range?
>
> Right.  We could avoid introducing acpi_mmio and instead storing the
> banks info in bootinfo.mem, that I am guessing it would be unused on
> acpi?

It's used by EFI to store the memory bank. So we can't reuse it for 
another purpose.

But we could extend the structure to add a type.

Although, let's wait until we know if we can use UEFI to get the MMIO 
region.

>
>> I guess it might be good, but I'm concerned about the static size of the
>> array, 64 may not be suffisant.
>
> Yes, you are right about that.  Do we have any ideas on how many banks
> are available on a few real systems?

I have no ideas.

> The alternative would be to create a list.

At that time, we can't use the boot allocator (memory has not been 
populate). We would have to use the AllocatePages().

Regards,

-- 
Julien Grall