From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Matt Fleming <matt.fleming@intel.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Patch 3/3] firmware: dmi_scan: use full dmi version for SMBIOS3
Date: Wed, 11 Feb 2015 12:08:01 +0200 [thread overview]
Message-ID: <54DB2A01.3090808@linaro.org> (raw)
In-Reply-To: <CAKv+Gu-zxcbJRzNB-fMBgagCP-Ob=aFEjBYKFSbEVmG6150-PQ@mail.gmail.com>
On 02/11/2015 11:55 AM, Ard Biesheuvel wrote:
> On 11 February 2015 at 17:46, Ivan Khoronzhuk
> <ivan.khoronzhuk@linaro.org> wrote:
>> New SMBIOS3 spec adds additional field for versioning - docrev.
>> The docrev identifies the revision of a specification implemented in
>> the table structures, so display SMBIOS version > 3 in format,
>> like: 3.22.1
>>
>> It's not affect on other part of code because version number
>> is analyzed using comparing, and it's obvious that 0x000208 is less
>> than 0x030201 for example.
>>
> I don't think the spec forbids passing a 3.0+ table using the legacy
> 32-bit entry point, in which case the packing of the version could
> potentially become a problem.
>
> I don't care deeply about the docrev, so I think we could drop this
> patch, but if others feel differently, could we at least pack the
> version in a consistent manner (i.e., always account for docrev, and
> set it to 0 if the 32-bit entry point is used?)
>
If others are OK, I can add docrev for 32 bit 3+ versions.
prev parent reply other threads:[~2015-02-11 10:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 9:46 [Patch 0/3] firmware: dmi_scan: add some SMBIOSv3 corrections Ivan Khoronzhuk
2015-02-11 9:46 ` [Patch 1/3] firmware: dmi_scan: use direct access to static vars Ivan Khoronzhuk
2015-02-11 9:46 ` [Patch 2/3] firmware: dmi_scan: fix dmi_len type Ivan Khoronzhuk
2015-02-11 9:53 ` Ard Biesheuvel
2015-02-11 10:10 ` Ivan Khoronzhuk
2015-02-11 10:12 ` Ard Biesheuvel
2015-02-13 16:12 ` Matt Fleming
2015-02-15 7:11 ` Ivan Khoronzhuk
2015-02-11 9:46 ` [Patch 3/3] firmware: dmi_scan: use full dmi version for SMBIOS3 Ivan Khoronzhuk
2015-02-11 9:55 ` Ard Biesheuvel
2015-02-11 10:08 ` Ivan Khoronzhuk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DB2A01.3090808@linaro.org \
--to=ivan.khoronzhuk@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=leif.lindholm@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.