From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Matt Fleming <matt.fleming@intel.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Patch 2/3] firmware: dmi_scan: fix dmi_len type
Date: Wed, 11 Feb 2015 12:10:24 +0200 [thread overview]
Message-ID: <54DB2A90.4070902@linaro.org> (raw)
In-Reply-To: <CAKv+Gu9h_E=GCFPokfWpS1AXKfzoSTM3LAt31hwOpJq0SO8XbA@mail.gmail.com>
On 02/11/2015 11:53 AM, Ard Biesheuvel wrote:
> On 11 February 2015 at 17:46, Ivan Khoronzhuk
> <ivan.khoronzhuk@linaro.org> wrote:
>> According to SMBIOSv3 specification the length of DMI table can be
>> up to 32bits wide. So use appropriate type to avoid overflow.
>>
>> It's obvious that dmi_num theoretically can be more than u16 also,
>> so it's can be changed to u32 or at least it's better to use int
>> instead of u16, but on that moment I cannot imagine dmi structure
>> count more than 65535 and it can require changing type of vars that
>> work with it. So I didn't correct it.
>>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> Acked-by: Ard Biesheuvel <ard@linaro.org>
>
> This should get a cc stable as well.
>
Pay attention that this patch has to be applied with patch 1/3.
next prev parent reply other threads:[~2015-02-11 10:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 9:46 [Patch 0/3] firmware: dmi_scan: add some SMBIOSv3 corrections Ivan Khoronzhuk
2015-02-11 9:46 ` [Patch 1/3] firmware: dmi_scan: use direct access to static vars Ivan Khoronzhuk
2015-02-11 9:46 ` [Patch 2/3] firmware: dmi_scan: fix dmi_len type Ivan Khoronzhuk
2015-02-11 9:53 ` Ard Biesheuvel
2015-02-11 10:10 ` Ivan Khoronzhuk [this message]
2015-02-11 10:12 ` Ard Biesheuvel
2015-02-13 16:12 ` Matt Fleming
2015-02-15 7:11 ` Ivan Khoronzhuk
2015-02-11 9:46 ` [Patch 3/3] firmware: dmi_scan: use full dmi version for SMBIOS3 Ivan Khoronzhuk
2015-02-11 9:55 ` Ard Biesheuvel
2015-02-11 10:08 ` Ivan Khoronzhuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DB2A90.4070902@linaro.org \
--to=ivan.khoronzhuk@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=leif.lindholm@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.