From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] cutils: refine strtol error handling in parse_debug_env
Date: Wed, 11 Feb 2015 06:42:43 -0700 [thread overview]
Message-ID: <54DB5C53.1070601@redhat.com> (raw)
In-Reply-To: <1423654243-20992-1-git-send-email-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
On 02/11/2015 04:30 AM, Paolo Bonzini wrote:
> Avoid truncation of a 64-bit long to a 32-bit int, and check for errno
> (especially ERANGE).
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> v1->v2: clear errno before strtol
> ---
> util/cutils.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] cutils: refine strtol error handling in parse_debug_env
Date: Wed, 11 Feb 2015 06:42:43 -0700 [thread overview]
Message-ID: <54DB5C53.1070601@redhat.com> (raw)
In-Reply-To: <1423654243-20992-1-git-send-email-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
On 02/11/2015 04:30 AM, Paolo Bonzini wrote:
> Avoid truncation of a 64-bit long to a 32-bit int, and check for errno
> (especially ERANGE).
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> v1->v2: clear errno before strtol
> ---
> util/cutils.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-02-11 13:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 11:30 [Qemu-trivial] [PATCH] cutils: refine strtol error handling in parse_debug_env Paolo Bonzini
2015-02-11 11:30 ` [Qemu-devel] " Paolo Bonzini
2015-02-11 13:42 ` Eric Blake [this message]
2015-02-11 13:42 ` Eric Blake
2015-02-16 8:28 ` [Qemu-trivial] " Michael Tokarev
2015-02-16 8:28 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DB5C53.1070601@redhat.com \
--to=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.