From: Guenter Roeck <linux@roeck-us.net>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Wim Van Sebroeck <wim@iguana.be>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
linux-watchdog@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] watchdog: mtk_wdt: signedness bug in mtk_wdt_start()
Date: Wed, 11 Feb 2015 14:01:25 +0000 [thread overview]
Message-ID: <54DB60B5.4040403@roeck-us.net> (raw)
In-Reply-To: <20150211102621.GC18515@mwanda>
On 02/11/2015 02:26 AM, Dan Carpenter wrote:
> "ret" should be signed for the error handling to work correctly. This
> doesn't matter much in real life since mtk_wdt_set_timeout() always
> succeeds.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Wim Van Sebroeck <wim@iguana.be>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
linux-watchdog@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] watchdog: mtk_wdt: signedness bug in mtk_wdt_start()
Date: Wed, 11 Feb 2015 06:01:25 -0800 [thread overview]
Message-ID: <54DB60B5.4040403@roeck-us.net> (raw)
In-Reply-To: <20150211102621.GC18515@mwanda>
On 02/11/2015 02:26 AM, Dan Carpenter wrote:
> "ret" should be signed for the error handling to work correctly. This
> doesn't matter much in real life since mtk_wdt_set_timeout() always
> succeeds.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
next prev parent reply other threads:[~2015-02-11 14:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 10:26 [patch] watchdog: mtk_wdt: signedness bug in mtk_wdt_start() Dan Carpenter
2015-02-11 10:26 ` Dan Carpenter
2015-02-11 10:47 ` Matthias Brugger
2015-02-11 10:47 ` Matthias Brugger
2015-02-11 14:01 ` Guenter Roeck [this message]
2015-02-11 14:01 ` Guenter Roeck
2015-03-24 8:18 ` Wim Van Sebroeck
2015-03-24 8:18 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DB60B5.4040403@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.