From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Wed, 11 Feb 2015 14:01:25 +0000 Subject: Re: [patch] watchdog: mtk_wdt: signedness bug in mtk_wdt_start() Message-Id: <54DB60B5.4040403@roeck-us.net> List-Id: References: <20150211102621.GC18515@mwanda> In-Reply-To: <20150211102621.GC18515@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Wim Van Sebroeck Cc: Matthias Brugger , linux-watchdog@vger.kernel.org, kernel-janitors@vger.kernel.org On 02/11/2015 02:26 AM, Dan Carpenter wrote: > "ret" should be signed for the error handling to work correctly. This > doesn't matter much in real life since mtk_wdt_set_timeout() always > succeeds. > > Signed-off-by: Dan Carpenter Reviewed-by: Guenter Roeck From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bh-25.webhostbox.net ([208.91.199.152]:55901 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752448AbbBKOB6 (ORCPT ); Wed, 11 Feb 2015 09:01:58 -0500 Received: from mailnull by bh-25.webhostbox.net with sa-checked (Exim 4.82) (envelope-from ) id 1YLXrS-001uEY-Rg for linux-watchdog@vger.kernel.org; Wed, 11 Feb 2015 14:01:51 +0000 Message-ID: <54DB60B5.4040403@roeck-us.net> Date: Wed, 11 Feb 2015 06:01:25 -0800 From: Guenter Roeck MIME-Version: 1.0 To: Dan Carpenter , Wim Van Sebroeck CC: Matthias Brugger , linux-watchdog@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] watchdog: mtk_wdt: signedness bug in mtk_wdt_start() References: <20150211102621.GC18515@mwanda> In-Reply-To: <20150211102621.GC18515@mwanda> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On 02/11/2015 02:26 AM, Dan Carpenter wrote: > "ret" should be signed for the error handling to work correctly. This > doesn't matter much in real life since mtk_wdt_set_timeout() always > succeeds. > > Signed-off-by: Dan Carpenter Reviewed-by: Guenter Roeck