* [patch] watchdog: mtk_wdt: signedness bug in mtk_wdt_start()
@ 2015-02-11 10:26 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2015-02-11 10:26 UTC (permalink / raw)
To: Wim Van Sebroeck; +Cc: Matthias Brugger, linux-watchdog, kernel-janitors
"ret" should be signed for the error handling to work correctly. This
doesn't matter much in real life since mtk_wdt_set_timeout() always
succeeds.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
index a87f6df..938b987 100644
--- a/drivers/watchdog/mtk_wdt.c
+++ b/drivers/watchdog/mtk_wdt.c
@@ -133,7 +133,7 @@ static int mtk_wdt_start(struct watchdog_device *wdt_dev)
u32 reg;
struct mtk_wdt_dev *mtk_wdt = watchdog_get_drvdata(wdt_dev);
void __iomem *wdt_base = mtk_wdt->wdt_base;
- u32 ret;
+ int ret;
ret = mtk_wdt_set_timeout(wdt_dev, wdt_dev->timeout);
if (ret < 0)
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [patch] watchdog: mtk_wdt: signedness bug in mtk_wdt_start()
@ 2015-02-11 10:26 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2015-02-11 10:26 UTC (permalink / raw)
To: Wim Van Sebroeck; +Cc: Matthias Brugger, linux-watchdog, kernel-janitors
"ret" should be signed for the error handling to work correctly. This
doesn't matter much in real life since mtk_wdt_set_timeout() always
succeeds.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
index a87f6df..938b987 100644
--- a/drivers/watchdog/mtk_wdt.c
+++ b/drivers/watchdog/mtk_wdt.c
@@ -133,7 +133,7 @@ static int mtk_wdt_start(struct watchdog_device *wdt_dev)
u32 reg;
struct mtk_wdt_dev *mtk_wdt = watchdog_get_drvdata(wdt_dev);
void __iomem *wdt_base = mtk_wdt->wdt_base;
- u32 ret;
+ int ret;
ret = mtk_wdt_set_timeout(wdt_dev, wdt_dev->timeout);
if (ret < 0)
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [patch] watchdog: mtk_wdt: signedness bug in mtk_wdt_start()
2015-02-11 10:26 ` Dan Carpenter
@ 2015-02-11 10:47 ` Matthias Brugger
-1 siblings, 0 replies; 8+ messages in thread
From: Matthias Brugger @ 2015-02-11 10:47 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Wim Van Sebroeck, linux-watchdog, kernel-janitors
2015-02-11 11:26 GMT+01:00 Dan Carpenter <dan.carpenter@oracle.com>:
> "ret" should be signed for the error handling to work correctly. This
> doesn't matter much in real life since mtk_wdt_set_timeout() always
> succeeds.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
> index a87f6df..938b987 100644
> --- a/drivers/watchdog/mtk_wdt.c
> +++ b/drivers/watchdog/mtk_wdt.c
> @@ -133,7 +133,7 @@ static int mtk_wdt_start(struct watchdog_device *wdt_dev)
> u32 reg;
> struct mtk_wdt_dev *mtk_wdt = watchdog_get_drvdata(wdt_dev);
> void __iomem *wdt_base = mtk_wdt->wdt_base;
> - u32 ret;
> + int ret;
>
> ret = mtk_wdt_set_timeout(wdt_dev, wdt_dev->timeout);
> if (ret < 0)
--
motzblog.wordpress.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] watchdog: mtk_wdt: signedness bug in mtk_wdt_start()
@ 2015-02-11 10:47 ` Matthias Brugger
0 siblings, 0 replies; 8+ messages in thread
From: Matthias Brugger @ 2015-02-11 10:47 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Wim Van Sebroeck, linux-watchdog, kernel-janitors
2015-02-11 11:26 GMT+01:00 Dan Carpenter <dan.carpenter@oracle.com>:
> "ret" should be signed for the error handling to work correctly. This
> doesn't matter much in real life since mtk_wdt_set_timeout() always
> succeeds.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
> index a87f6df..938b987 100644
> --- a/drivers/watchdog/mtk_wdt.c
> +++ b/drivers/watchdog/mtk_wdt.c
> @@ -133,7 +133,7 @@ static int mtk_wdt_start(struct watchdog_device *wdt_dev)
> u32 reg;
> struct mtk_wdt_dev *mtk_wdt = watchdog_get_drvdata(wdt_dev);
> void __iomem *wdt_base = mtk_wdt->wdt_base;
> - u32 ret;
> + int ret;
>
> ret = mtk_wdt_set_timeout(wdt_dev, wdt_dev->timeout);
> if (ret < 0)
--
motzblog.wordpress.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] watchdog: mtk_wdt: signedness bug in mtk_wdt_start()
2015-02-11 10:26 ` Dan Carpenter
@ 2015-02-11 14:01 ` Guenter Roeck
-1 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2015-02-11 14:01 UTC (permalink / raw)
To: Dan Carpenter, Wim Van Sebroeck
Cc: Matthias Brugger, linux-watchdog, kernel-janitors
On 02/11/2015 02:26 AM, Dan Carpenter wrote:
> "ret" should be signed for the error handling to work correctly. This
> doesn't matter much in real life since mtk_wdt_set_timeout() always
> succeeds.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] watchdog: mtk_wdt: signedness bug in mtk_wdt_start()
@ 2015-02-11 14:01 ` Guenter Roeck
0 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2015-02-11 14:01 UTC (permalink / raw)
To: Dan Carpenter, Wim Van Sebroeck
Cc: Matthias Brugger, linux-watchdog, kernel-janitors
On 02/11/2015 02:26 AM, Dan Carpenter wrote:
> "ret" should be signed for the error handling to work correctly. This
> doesn't matter much in real life since mtk_wdt_set_timeout() always
> succeeds.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] watchdog: mtk_wdt: signedness bug in mtk_wdt_start()
2015-02-11 10:26 ` Dan Carpenter
@ 2015-03-24 8:18 ` Wim Van Sebroeck
-1 siblings, 0 replies; 8+ messages in thread
From: Wim Van Sebroeck @ 2015-03-24 8:18 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Matthias Brugger, linux-watchdog, kernel-janitors
Hi Dan,
> "ret" should be signed for the error handling to work correctly. This
> doesn't matter much in real life since mtk_wdt_set_timeout() always
> succeeds.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
> index a87f6df..938b987 100644
> --- a/drivers/watchdog/mtk_wdt.c
> +++ b/drivers/watchdog/mtk_wdt.c
> @@ -133,7 +133,7 @@ static int mtk_wdt_start(struct watchdog_device *wdt_dev)
> u32 reg;
> struct mtk_wdt_dev *mtk_wdt = watchdog_get_drvdata(wdt_dev);
> void __iomem *wdt_base = mtk_wdt->wdt_base;
> - u32 ret;
> + int ret;
>
> ret = mtk_wdt_set_timeout(wdt_dev, wdt_dev->timeout);
> if (ret < 0)
Added to linux-watchdog-next. Will go upstream in 2 days.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] watchdog: mtk_wdt: signedness bug in mtk_wdt_start()
@ 2015-03-24 8:18 ` Wim Van Sebroeck
0 siblings, 0 replies; 8+ messages in thread
From: Wim Van Sebroeck @ 2015-03-24 8:18 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Matthias Brugger, linux-watchdog, kernel-janitors
Hi Dan,
> "ret" should be signed for the error handling to work correctly. This
> doesn't matter much in real life since mtk_wdt_set_timeout() always
> succeeds.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
> index a87f6df..938b987 100644
> --- a/drivers/watchdog/mtk_wdt.c
> +++ b/drivers/watchdog/mtk_wdt.c
> @@ -133,7 +133,7 @@ static int mtk_wdt_start(struct watchdog_device *wdt_dev)
> u32 reg;
> struct mtk_wdt_dev *mtk_wdt = watchdog_get_drvdata(wdt_dev);
> void __iomem *wdt_base = mtk_wdt->wdt_base;
> - u32 ret;
> + int ret;
>
> ret = mtk_wdt_set_timeout(wdt_dev, wdt_dev->timeout);
> if (ret < 0)
Added to linux-watchdog-next. Will go upstream in 2 days.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-03-24 8:18 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-11 10:26 [patch] watchdog: mtk_wdt: signedness bug in mtk_wdt_start() Dan Carpenter
2015-02-11 10:26 ` Dan Carpenter
2015-02-11 10:47 ` Matthias Brugger
2015-02-11 10:47 ` Matthias Brugger
2015-02-11 14:01 ` Guenter Roeck
2015-02-11 14:01 ` Guenter Roeck
2015-03-24 8:18 ` Wim Van Sebroeck
2015-03-24 8:18 ` Wim Van Sebroeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.